git-repo/.flake8

[flake8]
max-line-length = 80
per-file-ignores =
    # E501: line too long
    tests/test_git_superproject.py: E501
extend-ignore =
    # E203: Whitespace before ':'
    # See https://github.com/PyCQA/pycodestyle/issues/373
    E203,
    # E402: Module level import not at top of file
    E402,
    # E731: do not assign a lambda expression, use a def
    E731,
exclude =
    venv,
    .tox,
Replace pylint with pyflakes/flake8 pylint reports a lot of warnings, but many of them are false positive, and it's difficult to configure it. It also seems that for some reason the included config file is not working well with the latest version. Update the documentation to recommend using pyflakes and flake8 instead of pylint. Remove the pylint config and add a basic flake8 config with minimum settings: - Maximum line length 80 columns - Ignore warnings about indentation (repo uses 2 rather than expected 4) - Ignore warnings about import placement In this commit no code cleanup is done, and it's expected that most of the files will throw up quite a few warnings, at least for flake8. These can be cleaned up in follow-up commits. The existing pylint suppression comments are left as-is. These will be helpful when cleaning up pyflakes warnings later. Change-Id: I2f7cb4340266ed07cc973ca6483b8f09d66a765b 2016-09-02 13:20:38 +08:00			`[flake8]`
Make black with line length 80 repo's code style Provide a consistent formatting style and tox commands to lint and format. Bug: b/267675342 Change-Id: I33ddfe07af8473f4334c347d156246bfb66d4cfe Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/362954 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Mike Frysinger <vapier@google.com> Tested-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> 2023-03-11 12:35:22 +08:00			`max-line-length = 80`
Format codebase with black and check formatting in CQ Apply rules set by https://gerrit-review.googlesource.com/c/git-repo/+/362954/ across the codebase and fix any lingering errors caught by flake8. Also check black formatting in run_tests (and CQ). Bug: b/267675342 Change-Id: I972d77649dac351150dcfeb1cd1ad0ea2efc1956 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/363474 Reviewed-by: Mike Frysinger <vapier@google.com> Tested-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> 2023-03-11 14:46:20 +08:00			`per-file-ignores =`
			`# E501: line too long`
			`tests/test_git_superproject.py: E501`
Make black with line length 80 repo's code style Provide a consistent formatting style and tox commands to lint and format. Bug: b/267675342 Change-Id: I33ddfe07af8473f4334c347d156246bfb66d4cfe Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/362954 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Mike Frysinger <vapier@google.com> Tested-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> 2023-03-11 12:35:22 +08:00			`extend-ignore =`
			`# E203: Whitespace before ':'`
			`# See https://github.com/PyCQA/pycodestyle/issues/373`
			`E203,`
flake8: Add comments in config to explain suppressed checks Change-Id: Ib5c09b36d40a96ba9167b42b3bd2f1ed072660b7 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/254611 Tested-by: David Pursehouse <dpursehouse@collab.net> Reviewed-by: Mike Frysinger <vapier@google.com> 2020-02-12 15:42:39 +08:00			`# E402: Module level import not at top of file`
			`E402,`
flake8: Suppress "E731 do not assign a lambda expression, use a def" The Google Python Style Guide [1] says that lambdas are OK for one-liners. All the current usages are one-liners, so let's just suppress it. [1] http://google.github.io/styleguide/pyguide.html#210-lambda-functions Change-Id: I404c7a8e5e71870caf0f4604862cbf01db495863 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/255038 Tested-by: David Pursehouse <dpursehouse@collab.net> Reviewed-by: Mike Frysinger <vapier@google.com> 2020-02-15 10:43:24 +08:00			`# E731: do not assign a lambda expression, use a def`
			`E731,`
flake8: exclude venv and .tox folder Excluding these two folders to avoid countless lint warnings caused by dependencies in these two folders. Change-Id: I2403b23f88cebb5941a4f9b5ac6cc34d107fd2f1 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/382837 Commit-Queue: Daniel Kutik <daniel.kutik@lavawerk.com> Tested-by: Daniel Kutik <daniel.kutik@lavawerk.com> Reviewed-by: Mike Frysinger <vapier@google.com> 2023-08-15 19:23:15 +08:00			`exclude =`
			`venv,`
			`.tox,`