git-repo/.flake8

[flake8]
max-line-length=100
ignore=
    # E111: Indentation is not a multiple of four
    E111,
    # E114: Indentation is not a multiple of four (comment)
    E114,
    # E402: Module level import not at top of file
    E402,
    # E731: do not assign a lambda expression, use a def
    E731,
    # W503: Line break before binary operator
    W503,
    # W504: Line break after binary operator
    W504
Replace pylint with pyflakes/flake8 pylint reports a lot of warnings, but many of them are false positive, and it's difficult to configure it. It also seems that for some reason the included config file is not working well with the latest version. Update the documentation to recommend using pyflakes and flake8 instead of pylint. Remove the pylint config and add a basic flake8 config with minimum settings: - Maximum line length 80 columns - Ignore warnings about indentation (repo uses 2 rather than expected 4) - Ignore warnings about import placement In this commit no code cleanup is done, and it's expected that most of the files will throw up quite a few warnings, at least for flake8. These can be cleaned up in follow-up commits. The existing pylint suppression comments are left as-is. These will be helpful when cleaning up pyflakes warnings later. Change-Id: I2f7cb4340266ed07cc973ca6483b8f09d66a765b 2016-09-02 13:20:38 +08:00			`[flake8]`
flake8: Increase max line length from 80 to 100 The Google style guide for python [1] says the maximum line length should be 80, but there are several lines in the code base that exceed it: git ls-files \| grep py$ \| xargs flake8 \| grep E501 \| wc -l 64 I don't think it's worth going through and re-wrapping all those, so just increase the limit to 100 which seems to be a reasonable compromise: git ls-files \| grep py$ \| xargs flake8 \| grep E501 \| wc -l 6 Leave the re-rewrapping of those lines for a follow-up commit, though. [1] http://google.github.io/styleguide/pyguide.html#32-line-length Change-Id: Ia37c34301163431fd1fb4fb6697a4a482d6be077 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/254595 Tested-by: David Pursehouse <dpursehouse@collab.net> Reviewed-by: Mike Frysinger <vapier@google.com> 2020-02-12 10:39:27 +08:00			`max-line-length=100`
flake8: Add comments in config to explain suppressed checks Change-Id: Ib5c09b36d40a96ba9167b42b3bd2f1ed072660b7 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/254611 Tested-by: David Pursehouse <dpursehouse@collab.net> Reviewed-by: Mike Frysinger <vapier@google.com> 2020-02-12 15:42:39 +08:00			`ignore=`
			`# E111: Indentation is not a multiple of four`
			`E111,`
			`# E114: Indentation is not a multiple of four (comment)`
			`E114,`
			`# E402: Module level import not at top of file`
			`E402,`
flake8: Suppress "E731 do not assign a lambda expression, use a def" The Google Python Style Guide [1] says that lambdas are OK for one-liners. All the current usages are one-liners, so let's just suppress it. [1] http://google.github.io/styleguide/pyguide.html#210-lambda-functions Change-Id: I404c7a8e5e71870caf0f4604862cbf01db495863 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/255038 Tested-by: David Pursehouse <dpursehouse@collab.net> Reviewed-by: Mike Frysinger <vapier@google.com> 2020-02-15 10:43:24 +08:00			`# E731: do not assign a lambda expression, use a def`
			`E731,`
flake8: Add comments in config to explain suppressed checks Change-Id: Ib5c09b36d40a96ba9167b42b3bd2f1ed072660b7 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/254611 Tested-by: David Pursehouse <dpursehouse@collab.net> Reviewed-by: Mike Frysinger <vapier@google.com> 2020-02-12 15:42:39 +08:00			`# W503: Line break before binary operator`
			`W503,`
			`# W504: Line break after binary operator`
			`W504`