* Hello C# - Going to an official feature branch (#1544)
* change CalcViewModel into a WindowsRuntimeComponent project (#5)
* change CalcViewModel into a WindowsRuntimeComponent project
* remove the old UI codebase (#6)
* initially migrated C# codebase by tian (#7)
* initial migrated C# codebase by tian
* format the codebase
* resolve comments
* undo: modifications on UI test project
* Remove the blocks that have more than 1 empty line.
* Register DP using keyword 'nameof'
* C# Migration: Initially migrated C# codebase by Han (#8)
* C# Migration: Initially migrated C# codebase by Han
* Resolved comments and misssing asset
* Added three files to Calculator project
* Added TODO comment and updated Object
* NavCategory: temporary resolution of the hang issue (#9)
* Updated CalcViewModel and missing files (#10)
* Updated CalcViewModel and WinMeta
* Added Calculator.rc
* Resolved comment for InitializeLocalizationSettings
* add: views/unitconverter.xaml (#11)
* add: views/unitconverter.xaml
* format the code
* remove the extra empty line
* add an empty line
* check null before invoking event handlers (#12)
* fix problems of the migration of OBSERVABLE_PROPERTY_RW (#13)
* fixes crash in MathRichEditBox.ctor() (#14)
* fixes crash in MathRichEditBox.ctor()
* typo
* Update azure-pipelines.ci.yaml for Azure Pipelines
* Added a link copy of CalcViewModel to temporarily pass Unit Tests (#16)
* Updated CalcViewModelCopyForUT configuration (#17)
* changes output path of the UI project to align with other projects (#15)
* fixes EETypeLoadException issue: export class DelegateCommand (#18)
* fixes EETypeLoadException issue: export class DelegateCommand
* weak-reference in C++/CX
* WeakRef in C# codebase
* UTF-8-BOM
* spaces in macro
* resolve some comments from the offline review
* format
* rename file
* fixes the memory list issue (#20)
* fixes a wrongly migrated property
* UTF-8-BOM
* fixes up the crash of type casting (#21)
* Update localized strings 2021-01-04 (#1458) (#23)
(cherry picked from commit cdcb95656d)
Co-authored-by: Matt Cooley <macool@microsoft.com>
* Fixup tests (#1429) (#24)
- Removed unneeded "ToString" calls
- Fixed typos
- Renamed "fEButtonState" to "FEButtonState"
(cherry picked from commit 66ad328d00)
Co-authored-by: N <71219152+PokeCodec@users.noreply.github.com>
* Update graph internal engine verseion (#1466) (#25)
(cherry picked from commit 0048dcb500)
Co-authored-by: Quentin Al-Timimi <27322516+quentin987@users.noreply.github.com>
* Turn off DFS file shares in internal build system (#1470) (#26)
(cherry picked from commit 885fa23a89)
Co-authored-by: Matt Cooley <macool@microsoft.com>
* Improve clarity of math expressions in history for Standard Calculator (feature #138) (#1453) (#27)
* Implemented feature & added unit tests
* Fixed more unit/ui tests
* Refactored tests
* Update HistoryTests.cpp
* Update HistoryTests.cpp
* Update HistoryTests.cpp
* Update HistoryTests.cpp
* Update HistoryTests.cpp
* Update HistoryTests.cpp
* Update HistoryTests.cpp
* Update HistoryTests.cpp
(cherry picked from commit 565e3e2714)
Co-authored-by: Wei (Waley) Zhang <waley.zhang@microsoft.com>
* Adds unit-test cases for NarratorAnnouncement after fixing issue #1386 (#1469) (#28)
* fix bug: No confirmation is announced by the narrator after activating 'Remove equation' button #1386
* Unit Test: Add NarratorAnnouncementUnitTests
Co-authored-by: tain <tankle_@hotmail.com>
(cherry picked from commit 9d8e2ad18c)
Co-authored-by: Tian L <60599517+MSFT-Tilia@users.noreply.github.com>
* Move localization pipeline sync schedule to the YAML file (#1478) (#30)
(cherry picked from commit 007eccd940)
Co-authored-by: Matt Cooley <macool@microsoft.com>
* remove the strong reference carried from delegate (#32)
* Remove the finalizer of ControlSizeTrigger (#31)
* Normalize the namespace of CalcViewModel (#33)
* ViewMode: arrange namespaces
* UI build pass
* run release
* UT build pass
* pass build
* resolve comment: make the diff results cleaner
* resolve comment: make the diff results cleaner (2)
* resolve comment: make the diff results cleaner (3)
* resolve comment: move impl into a namespace
* update: spaces
* update: CalculatorButtonUser.h
* UTF-8 to UTF-8-BOM
* remove ViewState.h/.cpp from CalcViewModel path
* revert changes for NavCategory.cpp
* remove extra space
* remove UCM
* remove BOM
* Fixed a graphing calculator "permissions" bug caused by PR #1426 (#1471) (#34)
- The PR #1426 can cause a crash when no users are returned via `User::FindAllAsync(UserType::LocalUser)` when subsequently trying to access the first user. The existing code also does not guarantee that the returned user is the currently active user.
- This fix retrieves the user that opened the app and passes this user into a function to check if this user has the proper permissions to access the graphing mode. This makes sense since the active user is indistinguishable (at least from the app's perspective) to the user who opened the app. This user's permissions are then propagated downwards to properly set up the navigation menu of the app.
- Implementation detail worth pointing out: `s_categoryManifest` is what is used to populate the navigation menu of the app, but this variable is static by design, so a separate function was written to override the appropriate `isEnabled` value in `s_categoryManifest`. This function is called by `onLaunched`.
- Manual testing
Co-authored-by: Wei (Waley) Zhang <waley.zhang@microsoft.com>
* fixes up a bug (#35)
* fix csproj (#37)
Co-authored-by: hanzhang54 <zhangh@microsoft.com>
Co-authored-by: Matt Cooley <macool@microsoft.com>
Co-authored-by: N <71219152+PokeCodec@users.noreply.github.com>
Co-authored-by: Quentin Al-Timimi <27322516+quentin987@users.noreply.github.com>
Co-authored-by: Wei (Waley) Zhang <waley.zhang@microsoft.com>
Co-authored-by: Tian L <60599517+MSFT-Tilia@users.noreply.github.com>
* **BYPASS_SECRET_SCANNING** (#1546)
* Fixes a bug about the UI of expression tokens (#1547)
* fix
* [FeatureBranch] Fixes x86/ARM/ARM64 builds for the CI-Pipeline (#1550)
* **BYPASS_SECRET_SCANNING**
* fix
* fixes x86/ARM/ARM64 builds for CI-Pipeline
* Add headers missing for compilation with GCC (#1468) (#1551)
Things that required such update included:
* `wstringstream`
* `setprecision`
* `SCODE_CODE`, `E_BOUNDS`
* Various SAL macros
Co-authored-by: Michał Janiszewski <janisozaur@users.noreply.github.com>
* Update nuget.config file (#1486) (#1552)
Co-authored-by: Matt Cooley <macool@microsoft.com>
* Fixes up some simple miscellaneous TODO items (#1556)
* #DEBUG is a known C# preprocessor directive
* So far, we haven't observed the problem described in the comment from C# async
* fixes misc TODO items
* resolve some warnings (#1564)
* Add internal CI pipeline (#1553) (#1565)
* Add CI-internal pipeline
* No ARM64, to match release
Co-authored-by: Matt Cooley <macool@microsoft.com>
* Temporarily disable PGO NuGet package (#1510) (#1566)
Co-authored-by: Matt Cooley <macool@microsoft.com>
* [C# Calc]Removes WinMeta.cs (#1567)
* remove WinMeta.cs
* undo a trivial change
* UTF-8 BOM
* [C# Calc] Reverts some changes for Currency constants (#1570)
* Update2108release - experimental (#1572)
* adjusts Calculator.csproj (#1571)
* fixes BinSkim problems (#1573)
* fixes an issue around line style (#1575)
* fixes the missed NULLs (#1576) (#1578)
* Fix the Missing Part in Unit Converter Constructor (#1579)
* fixes: calculator doesn't remember its previous mode (#1580)
* Fixes: GraphingNumber doesn't work correctly (#1585)
* fixes: GraphingNumber doesn't work correctly
* Avoid crashing
* fixes binding (#1586)
* resolve TODO items (#1589)
* Improving keyboard support in VariableValueSlider (#1559) (#1595)
Co-authored-by: Dave Grochocki <grochocki@users.noreply.github.com>
* [C# Calc] Fixes: Keep the value away from getting rounded in Graphing Mode (#1596)
* keep the value away from getting rounded
* set the display precision to 6 to align with C++ impl
* fixes the button-light-up time (#1597)
* fixes up merging flaws
* Update2108release
* fixes (#1599)
* keep master for ci pipeline
* remove the Resources filter from CalcViewModel project
* removes `that` since `this` can be captured automatically
* AppxBundlePlatforms
* StampAssemblyInfo
* removes PreferredToolArchitecture
* Change the arg AppVersion into Version
* Change the arg AppVersion into Version
* from Calculator.rc to AssemblyInfo.cs
* Adds assembly-info
Co-authored-by: hanzhang54 <zhangh@microsoft.com>
Co-authored-by: Matt Cooley <macool@microsoft.com>
Co-authored-by: N <71219152+PokeCodec@users.noreply.github.com>
Co-authored-by: Quentin Al-Timimi <27322516+quentin987@users.noreply.github.com>
Co-authored-by: Wei (Waley) Zhang <waley.zhang@microsoft.com>
Co-authored-by: Tian L <60599517+MSFT-Tilia@users.noreply.github.com>
Co-authored-by: Michał Janiszewski <janisozaur@users.noreply.github.com>
Co-authored-by: Dave Grochocki <grochocki@users.noreply.github.com>
## Fixes a bug caused by https://github.com/microsoft/calculator/pull/1426#.
### Description of the changes:
- The PR #1426 can cause a crash when no users are returned via `User::FindAllAsync(UserType::LocalUser)` when subsequently trying to access the first user. The existing code also does not guarantee that the returned user is the currently active user.
- This fix retrieves the user that opened the app and passes this user into a function to check if this user has the proper permissions to access the graphing mode. This makes sense since the active user is indistinguishable (at least from the app's perspective) to the user who opened the app. This user's permissions are then propagated downwards to properly set up the navigation menu of the app.
- Implementation detail worth pointing out: `s_categoryManifest` is what is used to populate the navigation menu of the app, but this variable is static by design, so a separate function was written to override the appropriate `isEnabled` value in `s_categoryManifest`. This function is called by `onLaunched`.
### How changes were validated:
- Manual testing
* fix bug: No confirmation is announced by the narrator after activating 'Remove equation' button #1386
* Unit Test: Add NarratorAnnouncementUnitTests
Co-authored-by: tain <tankle_@hotmail.com>
* Use different formatter for different currency
* Add functional tests for currency fraction digit format
* Revert "Add functional tests for currency fraction digit format"
This reverts commit bd8aab33847425f4dcfd0d76ce310c918729b2fd.
* Add TestCurrencyFormattingLogic in UnitConverterViewModelUnitTests
* Fix InitializeMultipleConverterTest
* Add comment for a line of code
* Add default case for switch in ConvertToLocalizedString
* Remove trailing decimal
Disable decimal input if maxFractionDigits is 0
Fix input may be blocked after switched active
* Fix: UpdateIsDecimalEnabled should do nothing for non-currency converter
* Remove unnecessary SetValue method
* Add a comment
* Add functional UI Tests for currency converter
Reset currency before tests
Fix: input is blocked after switching to currency with less fractional digits
* Set Priority=0 for currency format related tests
* Truncate digits in display value after switcing
To fix incorrect result after switching currency with less fractional digits
Now that #744 has been fixed, I'm adding Test Method "KeyboardInput_HistoryHotkeys" to test the functionality of history hotkeys such as [Shift] + [Ctrl] + [D] to help prevent a regression or a break.
* Fixes issue #1409
Copy pasting into Currency locks the editor.
Skipping the validation of full editor lock when backspace or clear button is clicked.
* Adding code review feedback.
* Adding code review feedback.
When the unit converter's category is changed, the corresponding property setter for the CurrentCategory variable mistakenly calls OnPropertyChanged("CurrentCategory") instead of RaisePropertyChanged("CurrentCategory"). This results in a failure to notify XAML that the CurrentCategory variable has changed, resulting in the corresponding UI to not be updated accordingly.
* Fix typo in splash screen icon names
* Update the internals version to match the internal change
* Update the internals version to match the internal change
* Updated the CanFunctionAnalysisBePerformed api to use the updated one with variableIsNotX error handling. Updated the UI to reflect the new descriptive error case to show an informative error.
* Fixed spacing and updated the moved the variableIsNotX check up into the parent if statement
* Update the internals version to match the version needed to support this change
* Simplify KeyboardShortcutManager and correctly support Alt-Gr key
* replace multimap with map
move all global fields-functions to the class
* feedback
Co-authored-by: Eric Wong <eriwong@microsoft.com>
* Take the high boundary of signed negative values into account
* UI unit tests for the Copy/Paste menu are added
* Additional corner case for the number notations without negative values
* Revert "Updated the Calculator projects to include the /Z7 compiler flag (#1337)"
This reverts commit 6299ec2303.
* Update Calculator.vcxproj
Add %(AdditionalOptions) where it is missing
* Update TraceLogging.vcxproj
Updated the AdditionalOptions to add /await /std:c++17 /utf-8 so this project is consistent with the other projects.
* Change the initialization time of Radio button's isChecked
* Rollback checkDefaultBitShift and Use Enum instead of String
* Fix Check Default
- In previous versions, there was an issue where button availability was reset when opening BitShift Flyout not when the mode is changed
* Reset Calculator Type in Calculator ViewModel when mode change to not Calculator mode
* Revert "Reset Calculator Type in Calculator ViewModel when mode change to not Calculator mode"
This reverts commit a0d2f84513bc2d36fea3d75445782e1c67bc2e8d.
* Check deferred load button
The programmer radix buttons were being disabled when the bit flip panel was selected, causing keyboard events to be ignored.
They should actually only be hidden in bit flip mode.
- Corrected programmer radix buttons to continue being enabled just hidden when the programmer calculator is in bit flip mode.
- Renamed AreProgrammerRadixOperatorsEnabled property to the more appropriate AreProgrammerRadixOperatorsVisible.
* Added the /Z7 compiler flag
* added /Z7 compiler flag to remaining calculator projects
* Add %(AdditionalOptions) to complier configuration where it is missing
