Rudy Huyn
a6ac3bbeae
CalculationResult: keep focus on Scroll buttons ( #669 )
2020-04-07 17:08:43 -07:00
Rudy Huyn
825b42ad46
refactor HistoryTest.cpp to test the history using HistoryViewModel ( #784 )
...
* refactor HistoryTest
* modify MultiWindowUnitTests to not use m_standardCalcManager
* rebase
Co-authored-by: Rudy Huyn <rudy.huyn@microsoft.com>
2020-04-07 17:08:02 -07:00
Stephanie Anderl
0ed876db43
Added narrator announcement when a function is removed ( #1136 )
2020-04-07 11:20:14 -07:00
Rudy Huyn
6887c66be0
Revert "Revert WinUI version back to 2.2 ( #1113 )" ( #1147 )
2020-04-06 14:23:24 -07:00
dovisutu
5403adc914
Fix the operand order of logbasex for consistency ( #1115 )
...
* Fix #851 : inconsistent operand order for log_y(x)
- fixed the bug in scioper.cpp
- changed the related test in CalculatorUnitTests
- also changed the text in GraphingNumpad
* Change the name of LogBaseX for consistency
basically every occurence is repalced by logbasey, except
for the localized string for narrator, which I left for
the localization team to fix.
* Fix the test
* Revert GraphingNumPad.cpp
* Fixup according to review
2020-04-03 10:34:59 -07:00
Stephanie Anderl
2705bef6e9
Updated the focus state when the KGF Back Button is pressed to go to the EquationEditBox for the previously analyzed function. ( #1141 )
2020-04-02 12:53:21 -07:00
Stephanie Anderl
b93fe0b2b2
Update default min/max values for variables ( #1146 )
2020-04-02 12:52:52 -07:00
pi1024e
0550cb7e92
Simplify bools. ( #1116 )
2020-04-02 10:20:17 -07:00
Rudy Huyn
b0565f90f0
Revert dual screen ( #1134 )
2020-04-01 11:18:04 -07:00
Pepe Rivera
ded99f87b4
Fix trace value not appearing after touch input ( #1120 )
2020-04-01 09:12:14 -07:00
Pepe Rivera
25399c75d9
Make variable chevron focusable ( #1096 )
...
* give chevron focus
* fix merge issues
* fix key
2020-03-30 19:43:09 -07:00
Matt Cooley
f552428d97
Fix some code analysis warnings in CalcManager ( #1074 )
2020-03-30 15:23:22 -07:00
Stephanie Anderl
cf735bbcf5
Dark Theme For Graph Control ( #1106 )
...
* Added dark them to graph control, started dark theme for the controls on the graph
* Dark theme for graphing mode updated to use event model, diagnostics added, cleaned up code that wasn't needed
* Updated prepare-release-internalonly.yaml internal package version
* Updated Theme Settings properties, removed version change, other small changes from PR feedback>
* Updated the localSettings check and updated the GraphTheme event to send bool instead of string
* Updated the equation line color to change with the graph theme
* Rebased onto master and issues created during the rebase
* Updates per code review feedback
* Update settings properties to just have IsMatchAppTheme property and updated the high contrast settings for the graph control
* Match version to current in master
* Updated per PR feedback
* Fix resetting the m_lastLineColorIndex to only happen when reassignColors is true
* Changed second if to else if in the OnPropertyChanged method
* fixed control button and equation line colors
2020-03-27 17:20:35 -07:00
Matt Cooley
780e53780d
Check in localized strings 2020-03-24 ( #1109 )
2020-03-27 16:37:22 -07:00
Stephanie Anderl
d9b32a095f
Revert WinUI version back to 2.2 ( #1113 )
2020-03-27 12:17:11 -07:00
Pepe Rivera
fec7c907f8
Allow line style to be changed ( #1097 )
...
* add line style
* start line style
* More fixes
* undo key
* more tweaks
* address comments
* Fix merge
2020-03-27 09:56:11 -07:00
Pepe Rivera
7dcfe0439c
Add line width option ( #1098 )
...
* add line thickness
* clean up
* Fix pr comments
2020-03-26 14:15:44 -07:00
Pepe Rivera
fc19ddcbcb
Improve error handling by displaying an error message ( #1075 )
...
* wire up error messages
* more errors
* fix crash on render error
* Always show copy and cut
* PR comments
* Fix spelling
2020-03-25 15:18:34 -07:00
Jay Windsor
7b51b45906
Remove adjustment from local time ( #834 )
2020-03-25 04:20:13 -07:00
Rudy Huyn
15944fcd10
Add dual-screen support to Calculator ( #1027 )
2020-03-24 11:39:59 -07:00
Stephanie Anderl
ce86ed6819
Added Graphing Mode Jumplist Icons ( #1107 )
...
* Added Graphing jumplist icons to the assets folder and Calculator project
* Remove extra copy lines for the graphing engine dlls
2020-03-24 09:42:30 -07:00
Rudy Huyn
2b9e200945
remove the password from the certificate ( #1105 )
2020-03-23 17:37:22 -07:00
pi1024e
475aafdbc4
Replace old C headers with the C++ ones ( #1099 )
2020-03-23 08:44:06 -07:00
Matt Cooley
2d7133f5b7
Update TemporaryKey.pfx ( #1100 )
2020-03-23 07:42:54 -07:00
Pepe Rivera
28dbdb3d94
Persist variable settings after graph is plotted ( #1055 )
...
* Allow copying graph as image
* Persist variables
* Revert "Allow copying graph as image"
This reverts commit 4fc9d798bc5f3ff82efc4fb00140103213fb81e2.
* fix binding bug
* undo cert change
* fix animation
* remove extra lines
* remove overrides
* undo key comment
2020-03-17 11:27:00 -07:00
pi1024e
1b72ecb6b3
Remove unused "this" in async lambda expression ( #1094 )
2020-03-17 09:56:54 -07:00
pi1024e
172bf08122
No need to invoke the compare method when we have an overloaded == operator. ( #1091 )
2020-03-16 16:02:51 -07:00
pi1024e
d14423d0f1
Merge initializers and assignments ( #1088 )
2020-03-16 15:52:48 -07:00
Rudy Huyn
319f0e850c
Don't display the history button when the panel disappears ( #1081 )
2020-03-16 12:52:29 -07:00
Pepe Rivera
76fa670f92
Support mouse gestures when active tracing is enabled ( #1064 )
...
* Make the pointer follow the mouse
* Only render when necessary
* Move trace rendering to background thread
2020-03-16 11:54:19 -07:00
pi1024e
f527dce88d
Use static_cast instead of C-style cast in UnitConverter.cpp ( #1089 )
2020-03-16 09:29:58 -07:00
Matt Cooley
41dcbf53ec
Remove CMakeLists for now ( #1086 )
2020-03-13 12:40:57 -07:00
Scott Freeman
0490d8cd20
Reducing the number of wstring copies when constructing Unit and Category ( #936 )
2020-03-13 11:06:20 -07:00
Stephanie Anderl
18a1f82035
Graphing Calculator Diagnostics Instrumentation ( #1041 )
...
* Add telemetry for keyboard button usage in graphing mode
* Added the diagnostics for EquationAdded and FunctionAnalysis
* Added remaining diagnostics events for graphing calculator
* Fix proj files to include the IsStoreBuild condition. Move the Delayer class to the Calculator/Utils folder
* Ensure the variable textbox has focus before logging diagnostics
* Move maxVariableCount check into the tracelogger class
* Created enums and updated the slider value changed method to remove the variable from the map after the log method is called
* Re-enable hidden lines when the expression is updated
* Fixed extra line in grapher.h and removed the conditional logging for variable count
* Updated logging per PR feedback
* Updated variable logging and fixed issues in the IsEquationLineDisabled binding the EditTextBox control.
* Update per PR feedback
* Added TraceLogging project to contain shared logging logic.
* Updated TraceLogging project and updated tracelogger classes to use the TraceLogging project methods
* Updated VariableLogging to log variable name. And updated per PR comments
* Updated Variables logging to log count changed instead of variable added and fixed issue with variableSliders not being initialized
* Remove outdated tracelogging call caused by rebase
* Updated Delayer class to DispatcherTimerDelayer and fixed some small formatting issues
* Fixed missing Dalyer class name updates
* Removed extra line in traceloger.h
2020-03-12 14:05:47 -07:00
Pepe Rivera
102782df47
Select the equation when the EquationTextBox has focus and during analysis ( #1067 )
...
* Select equation on focus
* PR comment
2020-03-12 10:12:01 -07:00
Pepe Rivera
a2794b3705
Support regular textbox context menu functions in the EquationTextBox ( #1065 )
...
* Add context menu items back
* Disable if no selection
2020-03-11 18:38:12 -07:00
Stephanie Anderl
59c55a9333
Update the EquationInputArea divider line to update with the app theme ( #1084 )
2020-03-11 12:19:14 -07:00
Pepe Rivera
ebc57af203
Work around crash by replacing ItemRepeater with ListView ( #1058 )
...
* Replace ItemRepeater with ListView
* Allow animations
* undo temp key change
* Remove animation
2020-03-11 09:41:52 -07:00
Pepe Rivera
2caea01c6f
Fix analyze button being enabled with error ( #1061 )
2020-03-11 09:41:37 -07:00
Eric Wong
d11873caf6
Check for ctrl when navigating to handle AltGr ( #1054 )
2020-03-10 12:45:36 -07:00
Pepe Rivera
4f8db42855
Add reset button to settings flyout ( #1073 )
2020-03-09 16:51:39 -07:00
Pepe Rivera
1b1eb4c7e7
Add automation name to graph control ( #1032 )
...
* fix bugs
* Update src/Calculator/Resources/en-US/Resources.resw
Co-Authored-By: Rudy Huyn <rudyhuyn@gmail.com>
Co-authored-by: Rudy Huyn <rudyhuyn@gmail.com>
2020-03-06 16:25:50 -08:00
Pepe Rivera
de3a1cdff7
Allow copying graph as image ( #1051 )
2020-03-04 16:25:50 -08:00
Pepe Rivera
f1d53fba61
Support other locales for decimal and list separators ( #1060 )
...
* Support other locales for decimal and list seperators
* PR fixes
2020-03-04 15:15:18 -08:00
pi1024e
880072016f
Push back if the vector is a whimsical ( #1062 )
2020-03-03 13:47:26 -08:00
Pepe Rivera
814473f4d6
Parse each individual equation ( #1059 )
2020-03-03 10:53:03 -08:00
Pepe Rivera
dbc3dc5abb
Handle focus for clear and clearentry buttons ( #896 )
2020-03-03 10:52:48 -08:00
Stephanie Anderl
d7e7f46c99
Update Analysis after variables change ( #1056 )
...
* Updated Analyze Equation to set the current value of the variables before analysis
* Updated SetGraphArgs to take in a graph parameter and use it in AnalyzeEquation()
2020-02-28 09:34:16 -08:00
Pepe Rivera
915e0a8220
Pass EquationButtonContentIndex for show equation tooltip ( #1057 )
2020-02-27 14:28:18 -08:00
Pepe Rivera
f97c084a67
Fix some accessibility bugs ( #1047 )
...
* Fix accessibility bugs
* style fix
2020-02-27 11:54:29 -08:00
Pepe Rivera
0c8d6dd83c
Fix usability issues with settings flyout ( #1049 )
...
* various settings fixes
* PR fixes
2020-02-26 16:21:38 -08:00
Pepe Rivera
1f56b4946d
Delay loading some unused UI elements ( #1042 )
...
* unload
* pr fixes
2020-02-26 13:28:29 -08:00
Rudy Huyn
c0cb14a8e8
Make unit converters stil working when users opened 'Currency' in offline mode ( #1022 )
2020-02-25 16:34:18 -08:00
Pepe Rivera
dab258f3f0
share image ( #1039 )
2020-02-24 10:27:22 -08:00
Pepe Rivera
8483b68f12
Fix crash when tabbing through KGF ( #1037 )
...
* Check readonly
* Update src/Calculator/Controls/MathRichEditBox.cpp
Co-Authored-By: Rudy Huyn <rudyhuyn@gmail.com>
Co-authored-by: Rudy Huyn <rudyhuyn@gmail.com>
2020-02-14 15:01:43 -08:00
Pepe Rivera
11ab829b1b
Remove unneeded assets ( #1038 )
...
* remove fun assets
* PR comments
2020-02-14 14:56:54 -08:00
pi1024e
1ecf431ea3
No need to make an enum variable if it is either one of two possibilities. ( #1036 )
...
Visibility variable holding collapsed but then turning into visible is unnecessary when one can return Visibility::Collapsed or Visibility::Visible.
2020-02-14 12:52:58 -08:00
Crystal Edwards
d8fedaffde
Update Standard Mode Calculator UI Tests ( #788 )
...
Additional Standard mode UI Tests added.
2020-02-13 14:42:43 -08:00
Pepe Rivera
d196909246
Rename icons to new format and update internals package ( #1028 )
...
* Rename asset files
* Add missing files
* Exclude references to assets that don't exist
* Update internals version
2020-02-12 14:35:28 -08:00
Matt Cooley
7da1ab6874
Fix ARM64 build ( #1026 )
2020-02-11 14:03:43 -08:00
Stephanie Anderl
66e47627c0
Update the CI build to only run p0 UI tests for PRs and all UI tests for rolling CI builds ( #1012 )
...
* Added testcasefilter to the UI tests yaml
* Set priorities on UI tests
* Add UI tests for PRs yaml file, conditionally add it to the CI build yaml
* Update priority on functional tests
* Use a conditional task input instead of an additional yaml file to determine if UI tests should be filtered to P0 only
* Add condition:succeeded() back into the run-ui-tests.yaml
* Add back line
Co-authored-by: Matt Cooley <matt@mattcooley.net>
2020-02-07 15:12:31 -08:00
Pepe Rivera
724d12b762
Update mocks ( #967 )
2020-02-06 15:15:28 -08:00
Scott Freeman
4b9d6e9799
Making Graphing::Color fully constexpr ( #1010 )
2020-02-06 15:13:38 -08:00
Pepe Rivera
f1482252ef
Allow rendering the graph on a background thread ( #1014 )
...
* Render on background thread
* More work
* variable fix
* Add comments
2020-02-04 15:02:42 -08:00
Stephanie Anderl
f4ab94ce1c
Enables analysis on functions with variables ( #1021 )
...
* Add Graph Options to enable analysis with variables
* Remove debugging call to GetAllowKeyGraphFeaturesForFunctionsWithParameters()
* Updated the variable analysis logic to use the UpdateGraphOptions method
2020-02-04 13:43:00 -08:00
Pepe Rivera
6ca8f90021
Fix focus bug in graphing mode and other small changes ( #938 )
...
* Fix some bugs
* Style fixes from prev PR
2020-01-31 13:45:16 -08:00
Yair Aichenbaum
f2dbaad9b9
Always on top tool tip ( #968 )
...
* First implementation of KeyboardAccelerators for OnTop
* Changed shortcut keys to match the specs
* Adjusted ToolTips for compact overlay buttons to show the KeyboardAccelerator
2020-01-28 19:21:19 -08:00
Rudy Huyn
cdaf97e3d7
Update Calculator MDL2 Font( #972 )
2020-01-28 10:05:38 -08:00
Stephanie Anderl
c55797c933
Updated unit tests certificate ( #971 )
...
* Updated unit tests certificate
* Remove the user macros section since the certificate is already in the global section of the vcxproj
2020-01-27 11:25:33 -08:00
Pepe Rivera
350b8a9024
Fix graphing crash when plotting equations with errors ( #958 )
...
* fix crash
* Fix follow up crash
* real fix
2020-01-22 13:39:51 -08:00
Scott Freeman
e77823b97c
Fixing CalculatorManagerTests by setting calculator mode so CCalcEngine is set. ( #940 )
2020-01-17 20:19:17 -08:00
Scott Freeman
1947a25ff8
Making a few improvements in Grapher ( #922 )
...
- Removed unused variable
- Using ArrayReference in GetGraphBitmapStream so bytes aren't copied an extra time
2020-01-15 09:36:31 -08:00
Scott Freeman
52de42e7fb
Removing Utils::Swap and using std::swap instead ( #932 )
2020-01-14 15:22:50 -08:00
Pepe Rivera
ca0b3d83e8
fix bugs ( #934 )
2020-01-14 13:52:57 -08:00
Stephanie Anderl
9fc9c97ee7
Update KGF Back Button Styling ( #927 )
...
* Remove rounded corners on the back button
* Updated back button style to align with Equation button.
* Fixed issue where the forground color was white in high contrast and fixed the crash in high contrast
2020-01-13 15:09:45 -08:00
Pepe Rivera
3d1f0e9440
Make variable boxes collapsible on click ( #916 )
...
* fix
* PR comments
* fix bug
Co-authored-by: Eric Wong <eriwong@microsoft.com>
2020-01-13 10:08:23 -08:00
Scott Freeman
80e9b82bdc
Removing useless code from VisualTree::FindDescendantByName ( #925 )
2020-01-10 18:06:21 -08:00
Eric Wong
c7c9bf0513
Use path instead of glyph for active tracing ( #910 )
...
* Use path instead of glyph
2020-01-10 16:42:55 -08:00
Pepe Rivera
240792a775
Adjustments to ghost textbox ( #924 )
...
* adjustments
* delete extra visual states
* Fix hover bug
* Fix a few more bugs
* Fix high contrast crash
2020-01-10 16:41:23 -08:00
Stephanie Anderl
ab2ad8cdee
Update Font Sizes for Graph Settings and Key Graph Features to be aligned ( #923 )
...
* Updated fonts for Graph Settings to match KGF
* Update graph settings font sizes to be a bigger
* Update KGF fonts to match Graph Settings
2020-01-10 15:56:12 -08:00
Stephanie Anderl
42dcfdc598
Update group policy check to look in HKCU instead of HKLM for allowing graphing mode ( #918 )
...
* Update group policy check to look in HKCU instead of HKLM
* Update the dwFlags to use RRF_RT_DWORD.
2020-01-10 15:48:07 -08:00
Matt Cooley
6c524e68e2
Remove LimitedAccessFeatures check for old package name ( #921 )
2020-01-10 15:46:55 -08:00
Pepe Rivera
397c180d52
Format MathML equations before submission to the GraphControl ( #926 )
...
* Format richedit input
* fix spelling error
2020-01-10 15:17:36 -08:00
Pepe Rivera
c8a67eb574
ui changes ( #920 )
2020-01-09 14:10:48 -08:00
Rudy Huyn
9b9c9fb7ee
Fix function symbols in RtoL ( #914 )
2020-01-09 13:33:09 -08:00
Scott Freeman
bea4c2429f
Inferring std::array template params for featureLevels. ( #917 )
2020-01-09 12:05:49 -08:00
Scott Freeman
4f05b63ba6
Removing unnecessary string copies when iterating vectors and maps in KeyGraphFeaturesInfo ( #915 )
2020-01-09 12:05:16 -08:00
Rudy Huyn
6fe229fc15
Update toggle to switch from graph to equations ( #912 )
...
* Modify toggle to switch from graph to equations
* support RtoL languages
* fix margin
2020-01-09 09:44:46 -08:00
Pepe Rivera
9329af37f1
Fix crash when setting graph options to very large numbers ( #904 )
...
* fix crash
* Fixes
* Update build/pipelines/templates/build-app-internal.yaml
Co-Authored-By: Stephanie Anderl <46726333+sanderl@users.noreply.github.com>
Co-authored-by: Stephanie Anderl <46726333+sanderl@users.noreply.github.com>
2020-01-08 15:06:26 -08:00
Stephanie Anderl
c3414ea9c9
Change Calculator app name back to Calculator and add more margin to the preview tag for graphing mode ( #909 )
2020-01-08 14:56:44 -08:00
Scott Freeman
8141941208
Removing wstringstream usage since it adds unnecessary overhead ( #908 )
2020-01-08 14:35:05 -08:00
Rudy Huyn
f9c049a84b
Add preview tag to Graphing feature ( #907 )
...
* Add preview tag to Graphing
* Fix Graph Settings button in dark mode
2020-01-08 10:34:05 -08:00
Eric Wong (PAX)
09926e4f84
Fix build as a result of merge conflict
2020-01-07 14:26:40 -08:00
Eric Wong (PAX)
aad968ff37
Merge remote-tracking branch 'upstream/master' into mergeFeature
2020-01-07 14:08:18 -08:00
Rudy Huyn
2d177e5160
CalcViewModel code cleaning ( #754 )
...
* move KeyboardShortcutManager, ValidationConverter and ViewState to Calculator
* remove dead code listed in #753
* remove Microsoft.UI.Xaml nuget package from CalcViewModel
2020-01-07 13:59:51 -08:00
Eric Wong (PAX)
d087404256
One more unit test fix
2020-01-07 11:46:52 -08:00
Eric Wong (PAX)
967b2a1e86
More Unit tests fixes for when graphing calc is not enabled
2020-01-07 11:27:26 -08:00
Rudy Huyn
712bdb1b7c
Code cleaning: Remove all properties/functions not used in CalculationResult ( #649 )
2020-01-07 11:03:47 -08:00
Eric Wong (PAX)
40cadcda13
Add condition to unit tests to handle cases where graphing calculator is hidden
2020-01-06 16:04:27 -08:00
Rudy Huyn
7f2c300e37
remove the useless code related to the management of the focus in CalculationResult ( #700 )
2020-01-06 15:21:29 -08:00