de65db6197
Fixes #402 and #414 Divide by 4 the CPU usage of OverflowTextBlock when buttons are pressed very quickly. Description of the changes: Xaml-side: OverflowTextBlock has some performance issues: double scrollviewer: the listview was in a scrollviewer, while the control already containing one -> it breaks the virtualization of the listview and impacts on UI performance. The listview used a StackPanel, this panel doesn't support virtualization of ListViewItems contrary to ItemsStackPanel No ListView-specific features were used, an ItemsControl is more efficient and lighter. refactor how we manage the visibility of the left/right buttons in OverflowTextBlock, the new version is more reactive and will not display the right arrow when not necessary (see GIF below). remove the ItemContainerSelector ExpressionItemContainerStyle, not really used by OverflowTextBlock remove UI glitches generated by ChangeView when users type fast (control partially hidden and scrolling issues, see the GIF below). only modify the accessibility view when it's necessary ViewModel-side: stop fully refreshing ExpressionTokens in StandardCalculatorViewModel when a new command were sent, instead, use a IObservableVector to only send new tokens to the UI (in average only 1 or 2 UI items are refreshed while the full expression was refreshed before) How changes were validated: Manually |
||
|---|---|---|
| .. | ||
| Assets | ||
| Common | ||
| Controls | ||
| Converters | ||
| DesignData | ||
| Resources | ||
| Views | ||
| AboutFlyout.xaml | ||
| AboutFlyout.xaml.cpp | ||
| AboutFlyout.xaml.h | ||
| App.xaml | ||
| App.xaml.cpp | ||
| App.xaml.h | ||
| Calculator.rc | ||
| Calculator.vcxproj | ||
| Calculator.vcxproj.filters | ||
| Package.appxmanifest | ||
| packages.config | ||
| pch.cpp | ||
| pch.h | ||
| TemporaryKey.pfx | ||
| WindowFrameService.cpp | ||
| WindowFrameService.h | ||