* Replacing CalculatorVector usage with std::vector Assumptions made here are that memory allocations are not recoverable. If it can be proved that an index will be in range, then the indexing operation is used. If not (without manual checks) the std::vector::at function is used to throw an exception in case of a programmer bug. * Changes based on PR feedback Using auto& in CalculatorCollector::UpdateHistoryExpression so the token.first value is properly updated. Using range for loop to GenerateExpressions. Setting isEditable directly to the result of boolean expression. Using token.second directly instead of creating a separate tokenCommandIndex variable. * Fixing issue with generating expressions strings. A space should not be added before the first item.
77 lines
2.9 KiB
C++
77 lines
2.9 KiB
C++
// Copyright (c) Microsoft Corporation. All rights reserved.
|
|
// Licensed under the MIT License.
|
|
|
|
#pragma once
|
|
|
|
#include "CalcManager/ExpressionCommandInterface.h"
|
|
|
|
namespace CalculatorApp
|
|
{
|
|
namespace ViewModel
|
|
{
|
|
[Windows::UI::Xaml::Data::Bindable] public ref class HistoryItemViewModel sealed : Windows::UI::Xaml::Data::ICustomPropertyProvider
|
|
{
|
|
internal :
|
|
|
|
HistoryItemViewModel(
|
|
Platform::String ^ expression,
|
|
Platform::String ^ result,
|
|
_In_ std::shared_ptr<std::vector<std::pair<std::wstring, int>>> const& spTokens,
|
|
_In_ std::shared_ptr<std::vector<std::shared_ptr<IExpressionCommand>>> const& spCommands);
|
|
|
|
std::shared_ptr<std::vector<std::pair<std::wstring, int>>> const& GetTokens()
|
|
{
|
|
return m_spTokens;
|
|
}
|
|
|
|
std::shared_ptr<std::vector<std::shared_ptr<IExpressionCommand>>> const& GetCommands()
|
|
{
|
|
return m_spCommands;
|
|
}
|
|
|
|
public:
|
|
property Platform::String
|
|
^ Expression { Platform::String ^ get() { return m_expression; } }
|
|
|
|
property Platform::String
|
|
^ AccExpression { Platform::String ^ get() { return m_accExpression; } }
|
|
|
|
property Platform::String
|
|
^ Result { Platform::String ^ get() { return m_result; } }
|
|
|
|
property Platform::String
|
|
^ AccResult { Platform::String ^ get() { return m_accResult; } }
|
|
|
|
virtual Windows::UI::Xaml::Data::ICustomProperty
|
|
^ GetCustomProperty(Platform::String ^ name) { return nullptr; }
|
|
|
|
virtual Windows::UI::Xaml::Data::ICustomProperty
|
|
^ GetIndexedProperty(Platform::String ^ name, Windows::UI::Xaml::Interop::TypeName type) { return nullptr; }
|
|
|
|
virtual property Windows::UI::Xaml::Interop::TypeName Type
|
|
{
|
|
Windows::UI::Xaml::Interop::TypeName get()
|
|
{
|
|
return this->GetType();
|
|
}
|
|
}
|
|
|
|
virtual Platform::String
|
|
^ GetStringRepresentation() { return m_accExpression + " " + m_accResult; }
|
|
|
|
private : static Platform::String
|
|
^ GetAccessibleExpressionFromTokens(
|
|
_In_ std::shared_ptr<std::vector<std::pair<std::wstring, int>>> const& spTokens,
|
|
_In_ Platform::String ^ fallbackExpression);
|
|
|
|
private:
|
|
Platform::String ^ m_expression;
|
|
Platform::String ^ m_accExpression;
|
|
Platform::String ^ m_accResult;
|
|
Platform::String ^ m_result;
|
|
std::shared_ptr<std::vector<std::pair<std::wstring, int>>> m_spTokens;
|
|
std::shared_ptr<std::vector<std::shared_ptr<IExpressionCommand>>> m_spCommands;
|
|
};
|
|
}
|
|
}
|