Commit Graph

210 Commits

Author SHA1 Message Date
achmurali
ea61391a62
Disabled focus for 2nd button (#1523)
Co-authored-by: achmurali <achmurali@github.com>
2021-04-20 12:08:35 -07:00
Hongxu Xu
f910d64d88
Handle Space and Enter KeyDown event for About button (#1459) 2021-01-11 11:46:08 -08:00
Rudy Huyn
3172f7fea2
Prevents the user interface from shifting upwards at launch (#633)
Co-authored-by: Matt Cooley <macool@microsoft.com>
Co-authored-by: Pepe Rivera <joseartrivera@gmail.com>
2020-12-16 14:46:37 -08:00
Chaitanya Mehta
c4793785c3
Add link to GitHub repo on about flyout (#1449)
* Add link to GitHub repo on about flyout

* Update AboutFlyout page GitHub link margin.

* Update AboutPage GitHub link string.
2020-12-10 21:04:18 -08:00
Jack Rainy
903b231b1f
Edit fields are scalable for large fonts (#1401)
* Edit fields are scalable for large fonts

* Retain the initial width of edit fields, but scale if needed
2020-10-22 09:28:26 -07:00
Rudy Huyn
bc473617ae
Simplify KeyboardShortcutManager and correctly support Alt-Gr key (#1223)
* Simplify KeyboardShortcutManager and correctly support Alt-Gr key

* replace multimap with map
move all global fields-functions to the class

* feedback

Co-authored-by: Eric Wong <eriwong@microsoft.com>
2020-09-15 12:43:50 -07:00
Stephanie Anderl
503c27ae7b
Update WinUI Version to 2.4 (#1354)
* Updated to WinUI2.4 and fixed NavMenu about flyout and Dark Mode EquationEditBox

* Added updated equationbox background to the focusederror state
2020-09-01 16:48:22 -07:00
Lee Won Jun
9206520121
Change the initialization time of Radio button's isChecked (#1312)
* Change the initialization time of Radio button's isChecked

* Rollback checkDefaultBitShift and Use Enum instead of String

* Fix Check Default
- In previous versions, there was an issue where button availability was reset when opening BitShift Flyout not when the mode is changed

* Reset Calculator Type in Calculator ViewModel when mode change to not Calculator mode

* Revert "Reset Calculator Type in Calculator ViewModel when mode change to not Calculator mode"

This reverts commit a0d2f84513bc2d36fea3d75445782e1c67bc2e8d.

* Check deferred load button
2020-08-20 15:30:48 -07:00
Callum Shipton
95a1ba4c8c
'Keep on top' button appears last in the tab order (#1339) (#1347)
- Added TabIndex to AlwaysOnTop button
2020-08-12 09:14:45 -07:00
Callum Shipton
331388c000
Enable keyboard entry in bit-toggling mode #478 (#1346)
The programmer radix buttons were being disabled when the bit flip panel was selected, causing keyboard events to be ignored.
They should actually only be hidden in bit flip mode.

- Corrected programmer radix buttons to continue being enabled just hidden when the programmer calculator is in bit flip mode.
- Renamed AreProgrammerRadixOperatorsEnabled property to the more appropriate AreProgrammerRadixOperatorsVisible.
2020-08-12 08:53:31 -07:00
Rudy Huyn
1c8b642376
Remove ICustomPropertyProviders (#1229)
* Remove unused ICustomPropertyProviders
* Modify UI tests to not use Customproperties
2020-08-12 08:22:49 -07:00
Eric Tian
0e1c4f8cb4
CornerRadius! (#1321) 2020-07-21 14:28:47 -07:00
Eric Tian
7379876432
Fix accent colour mouse-over (#1315) 2020-07-21 09:23:49 -07:00
Vignesh M
264babc608
Resolution for Bit Shift radio button announcements (#1317) 2020-07-20 15:05:22 -07:00
Quentin Al-Timimi
0175b51655
Updated APIs to use new GetClosePointData() from Graphing Engine. (#1250)
* Updated APIs to use new GetClosePointData() from Graphing Engine. Now specifiying precision on API consumption to aid with correct display and rounding.

* Updated function to be const-corect

* Updated to use correct APIs

* Converted TraceValue from Point to two doubles, point's X and Y was using float and conversion between float and doubles was causing unwanted rounding.

* Update to pch file and fixing typo

* Point to updated graphing version
2020-06-30 15:08:54 -07:00
Vignesh M
a3163f64e3
Narrator reads incorrect information as “History and Memory list” in Programmer Calculator #1174 (#1286) 2020-06-26 14:38:42 -07:00
Pepe Rivera
876a7fe13c
Remove preview tag from graphing mode (#1285)
* Remove preview tag

* Remove preview tag

* fix bug
2020-06-23 13:06:23 -07:00
Pepe Rivera
81ea002cf9
Fix equations not getting focus after being removed (#1271) 2020-06-16 09:58:20 -07:00
Pepe Rivera
8f56ad0dc6
Fix tracing button not receiving focus after the 'esc' key is used to exit tracing mode (#1272) 2020-06-16 09:58:02 -07:00
Pepe Rivera
db15b602f9
Fix bitwise popup focus order (#1273) 2020-06-16 09:57:43 -07:00
Pepe Rivera
4c8e1cb5f0
Check for valid input in min/max/step fields (#1270) 2020-06-15 14:13:56 -07:00
Rudy Huyn
0a4296f06a
Modify how we manage round corners (#1261) 2020-06-02 12:58:47 -07:00
Quentin
178075d7d7
Setting IsEnabled to be conditional based on the AlwaysOnTop flag, (#1243) 2020-05-26 12:59:06 -05:00
Stephanie Anderl
9a07755620
Fixed narrator issues in KGF and GraphView button, updated Trig radio button corner radius (#1227)
* fixed the trig units radio buttons rounded corners and narrator issues in kgf and graph reset

* removed extra whitespace

* Update src/Calculator/Resources/en-US/Resources.resw

Co-authored-by: Eric Wong <eriwong@microsoft.com>

* Update src/Calculator/Resources/en-US/Resources.resw

Co-authored-by: Eric Wong <eriwong@microsoft.com>

Co-authored-by: Eric Wong <eriwong@microsoft.com>
2020-05-26 09:34:45 -07:00
Rudy Huyn
143907f21f
Remove dead code from History (#1228)
* Clean history

* clean unit tests

* cleaning

* Remove friend class in HistoryViewModel
2020-05-25 15:02:27 -07:00
Pepe Rivera
f2e423329d
Improve launch performance by delay loading NavigationView (#1213)
* Delay load graph engine

* Remove default behavior

* Delay load nav view

* Add automation properties

* clean up

* handle shortcut keys

* Include only navview changes

* Address PR comments

* manual merge fix

* PR Changes

* Undo other changes

* reset resw file

* fix margin
2020-05-19 09:58:11 -07:00
Rudy Huyn
80fbe891d6
Fix graph dark colors at launch (#1217) 2020-05-15 10:44:50 -07:00
Pepe Rivera
0f14e4f46e
Use ToggleButton for variable options chevron button (#1219)
* Use togglebutton instead

* Update src/Calculator/Views/GraphingCalculator/EquationInputArea.xaml

Co-authored-by: Rudy Huyn <rudyhuyn@gmail.com>

* Update src/Calculator/Views/GraphingCalculator/EquationInputArea.xaml

Co-authored-by: Rudy Huyn <rudyhuyn@gmail.com>

* undo pr suggestion

Co-authored-by: Rudy Huyn <rudyhuyn@gmail.com>
2020-05-13 18:42:35 -07:00
Rudy Huyn
7a6b0a72c3
Tweak UI: Title and History/Memory panels (#1215) 2020-05-11 16:38:45 -07:00
Pepe Rivera
1eda521992
fix style bugs in graph options (#1225) 2020-05-11 14:59:27 -07:00
Pepe Rivera
47760b4514
Don't submit equation when opening context menu (#1220)
* Don't submit equation when opening context menu

* Clean up
2020-05-08 18:50:22 -07:00
Pepe Rivera
66b64afd75
Fix styling bugs in graph settings and style panel (#1202) 2020-05-08 12:14:01 -07:00
Quentin
7b4ff49df8
Issue 935 - Updates to Scientific/Graphing Keypad (#1214)
* Switching from Difference between dates to Add or subtract dates ignores the first date field

https://github.com/microsoft/calculator/issues/254

Date field needs to persist across Date Difference and Add/Subtract From Date Mode.

* Update DateCalculator.xaml.cpp

Addressing review comments (white space, small code refactor), also found a null pointer exception during testing, this fix addresses that as well.

* Issue 935 - Updates to Scientific/Graphing Keypad

Update Scientific and Graphing keyboard layouts to expose square root button at the top level

* Updated ScientificModeFunctionalTests/SmokeTest_Cube()

Updated broken test to work with changes.
2020-05-08 12:32:17 -05:00
Stephanie Anderl
1e302cac58
Associate Units and Theme labels with the radio button groups (#1211)
* Wrap theme radio buttons in MUXC RadioButtons control to fix accessibility issue where the buttons are grouped with the theme title

* Associated theme labels with radio button groups
2020-05-07 16:41:08 -07:00
Quentin
fd48f6ec1d
Switching from Difference between dates to Add or subtract dates ignores the first date field (#1210) 2020-05-06 15:14:54 -07:00
Stephanie Anderl
3055a12178
Updated EquationButton contrast fixed dark mode foreground color bugs (#1155)
* Fixed contrast between background and foreground colors in the equation button. Fixed the issue where the text in the equation text box is white when the background is white

* Adjust the foreground color algorithm

* moved the contrast method to utils so that it is resuable

* Moved brushes for the GetContrastColor method to the app.xaml resource dictionary

* Removed the change for the edit box colors, so it can be in a different PR
2020-05-05 10:20:05 -07:00
Pepe Rivera
9817738307
Catch exception when trying to share (#1203)
* Fix crash

* Fix errors
2020-05-05 09:36:09 -07:00
Rudy Huyn
6e521d8f29
Remove LRE/LRO characters from results and error messages (#1161)
* Remove LRE/LRO characters and rely on Xaml to correctly displayed the numbers and error messages RtL

* unit tests
2020-04-30 12:04:33 -07:00
Pepe Rivera
c2c92f4006
Set IsTextScaleFactorEnabled to true for HEX, DEC, OCT, BIN buttons (#1157)
* fix scale factor

* Allow expression to scale
2020-04-24 10:03:04 -07:00
Pepe Rivera
db86e949f9
Don't create a new flyout every time the graph settings button is clicked (#1197)
* attempt a fix

* fix ranges
2020-04-24 10:02:44 -07:00
Pepe Rivera
0465dc8538
Change trace point value precision to be dynamic based on graph scale (#1148)
* Dynamic precision

* add comments

* feedback

* Update src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp

Co-Authored-By: Rudy Huyn <rudyhuyn@gmail.com>

* PR feedback

* Pr comment

Co-authored-by: Rudy Huyn <rudyhuyn@gmail.com>
2020-04-21 17:44:08 -07:00
Stephanie Anderl
1ded2c57db
Fixed crash when in high contrast (#1159)
* Fixed line colors out of bounds issue when switching to high contrast

* Update the fix to not reload the colors OnColorChanged when in HighContrast
2020-04-15 12:42:31 -07:00
Pepe Rivera
15b957c98b
Fix line becoming enabled on focus lost (#1167) 2020-04-14 15:51:17 -07:00
Stephanie Anderl
3a8fcaa18a
Update Icons Implement the Graph View Button (#1149)
* Update icon file

* function analysis and negate button icons updated

* Replace zoom reset button with graph view button

* Fixed issue where the window settings did not update after panning/zooming

* Updated icon styling and added logic for updating the graph view button state when user manipulates the graph and when all equations are removed

* updated LogGraphButton clicked to have an enum for the button value instead of a string

* Updated the logic for how to set the IsManualAdjustment, ensured graphsettings now update IsManualAdjustment when changed
2020-04-14 12:37:23 -07:00
Stephanie Anderl
7612b69949
Add Automation Names to the GraphNumPad (#1145)
* Turn off keyboard shortcuts when in graphing mode

* Added automation names to the graphnumpad, added any missing ones to the resources.resw file

* Remove HonorShortcuts call in the EquationInputArea, update Equal button automation name to use the existing one

* conditionally set the HonorShortcuts when the nav menu is closed

* added disable shortcuts to override HonorShortcuts when it is set
2020-04-14 12:37:00 -07:00
Rudy Huyn
0318c8f359
Delay load GraphingNumPad::buttonOutput to not call localizationSettings too early (#1162) 2020-04-10 11:23:42 -07:00
Pepe Rivera
3a808b5022
Update styling of graph settings textbox and add shadow (#1079)
* Update internal package vers

* fix more bugs

* PR comments

* PR comments

* Undo last PR changes

* Pr comments
2020-04-09 16:58:18 -07:00
Pepe Rivera
0a01a10566
Recycle equation colors when no longer in use (#1154)
* Fix two pane crash on closing window

* recycle equation colors

* PR comments
2020-04-09 16:58:08 -07:00
Stephanie Anderl
33b4d18638
Add Automation Names to UI Elements in EquationInputArea and KGF Panel (#1133)
* Missing EquationInputArea and KGF Automation Names added

* Updated the KGF back button automation name and tooltip and added the automation name string for the KGF equation edit box

* Reverted the removal of x:names and updated Variable Step Textbox to Variable Step Value Textbox per PR feedback

* Updated the VariableListViewItem narrator announcement to include the name of the variable
2020-04-09 13:16:05 -07:00
Pepe Rivera
07108af967
Fix crash when using "C" key to clear equation (#1152)
* Fix two pane crash on closing window

* clearcrash
2020-04-09 12:24:25 -07:00