Commit Graph

264 Commits

Author SHA1 Message Date
Rudy Huyn
2b9e200945
remove the password from the certificate (#1105) 2020-03-23 17:37:22 -07:00
Matt Cooley
2d7133f5b7
Update TemporaryKey.pfx (#1100) 2020-03-23 07:42:54 -07:00
Pepe Rivera
28dbdb3d94
Persist variable settings after graph is plotted (#1055)
* Allow copying graph as image

* Persist variables

* Revert "Allow copying graph as image"

This reverts commit 4fc9d798bc5f3ff82efc4fb00140103213fb81e2.

* fix binding bug

* undo cert change

* fix animation

* remove extra lines

* remove overrides

* undo key comment
2020-03-17 11:27:00 -07:00
Rudy Huyn
319f0e850c
Don't display the history button when the panel disappears (#1081) 2020-03-16 12:52:29 -07:00
Stephanie Anderl
18a1f82035
Graphing Calculator Diagnostics Instrumentation (#1041)
* Add telemetry for keyboard button usage in graphing mode

* Added the diagnostics for EquationAdded and FunctionAnalysis

* Added remaining diagnostics events for graphing calculator

* Fix proj files to include the IsStoreBuild condition. Move the Delayer class to the Calculator/Utils folder

* Ensure the variable textbox has focus before logging diagnostics

* Move maxVariableCount check into the tracelogger class

* Created enums and updated the slider value changed method to remove the variable from the map after the log method is called

* Re-enable hidden lines when the expression is updated

* Fixed extra line in grapher.h and removed the conditional logging for variable count

* Updated logging per PR feedback

* Updated variable logging and fixed issues in the IsEquationLineDisabled binding the EditTextBox control.

* Update per PR feedback

* Added TraceLogging project to contain shared logging logic.

* Updated TraceLogging project and updated tracelogger classes to use the TraceLogging project methods

* Updated VariableLogging to log variable name. And updated per PR comments

* Updated Variables logging to log count changed instead of variable added and fixed issue with variableSliders not being initialized

* Remove outdated tracelogging call caused by rebase

* Updated Delayer class to DispatcherTimerDelayer and fixed some small formatting issues

* Fixed missing Dalyer class name updates

* Removed extra line in traceloger.h
2020-03-12 14:05:47 -07:00
Pepe Rivera
102782df47
Select the equation when the EquationTextBox has focus and during analysis (#1067)
* Select equation on focus

* PR comment
2020-03-12 10:12:01 -07:00
Pepe Rivera
a2794b3705
Support regular textbox context menu functions in the EquationTextBox (#1065)
* Add context menu items back

* Disable if no selection
2020-03-11 18:38:12 -07:00
Stephanie Anderl
59c55a9333
Update the EquationInputArea divider line to update with the app theme (#1084) 2020-03-11 12:19:14 -07:00
Pepe Rivera
ebc57af203
Work around crash by replacing ItemRepeater with ListView (#1058)
* Replace ItemRepeater with ListView

* Allow animations

* undo temp key change

* Remove animation
2020-03-11 09:41:52 -07:00
Pepe Rivera
2caea01c6f
Fix analyze button being enabled with error (#1061) 2020-03-11 09:41:37 -07:00
Eric Wong
d11873caf6
Check for ctrl when navigating to handle AltGr (#1054) 2020-03-10 12:45:36 -07:00
Pepe Rivera
4f8db42855
Add reset button to settings flyout (#1073) 2020-03-09 16:51:39 -07:00
Pepe Rivera
1b1eb4c7e7
Add automation name to graph control (#1032)
* fix bugs

* Update src/Calculator/Resources/en-US/Resources.resw

Co-Authored-By: Rudy Huyn <rudyhuyn@gmail.com>

Co-authored-by: Rudy Huyn <rudyhuyn@gmail.com>
2020-03-06 16:25:50 -08:00
Pepe Rivera
de3a1cdff7
Allow copying graph as image (#1051) 2020-03-04 16:25:50 -08:00
Pepe Rivera
f1d53fba61
Support other locales for decimal and list separators (#1060)
* Support other locales for decimal and list seperators

* PR fixes
2020-03-04 15:15:18 -08:00
Pepe Rivera
dbc3dc5abb
Handle focus for clear and clearentry buttons (#896) 2020-03-03 10:52:48 -08:00
Pepe Rivera
915e0a8220
Pass EquationButtonContentIndex for show equation tooltip (#1057) 2020-02-27 14:28:18 -08:00
Pepe Rivera
f97c084a67
Fix some accessibility bugs (#1047)
* Fix accessibility bugs

* style fix
2020-02-27 11:54:29 -08:00
Pepe Rivera
0c8d6dd83c
Fix usability issues with settings flyout (#1049)
* various settings fixes

* PR fixes
2020-02-26 16:21:38 -08:00
Pepe Rivera
1f56b4946d
Delay loading some unused UI elements (#1042)
* unload

* pr fixes
2020-02-26 13:28:29 -08:00
Rudy Huyn
c0cb14a8e8
Make unit converters stil working when users opened 'Currency' in offline mode (#1022) 2020-02-25 16:34:18 -08:00
Pepe Rivera
dab258f3f0
share image (#1039) 2020-02-24 10:27:22 -08:00
Pepe Rivera
8483b68f12
Fix crash when tabbing through KGF (#1037)
* Check readonly

* Update src/Calculator/Controls/MathRichEditBox.cpp

Co-Authored-By: Rudy Huyn <rudyhuyn@gmail.com>

Co-authored-by: Rudy Huyn <rudyhuyn@gmail.com>
2020-02-14 15:01:43 -08:00
Pepe Rivera
11ab829b1b
Remove unneeded assets (#1038)
* remove fun assets

* PR comments
2020-02-14 14:56:54 -08:00
pi1024e
1ecf431ea3
No need to make an enum variable if it is either one of two possibilities. (#1036)
Visibility variable holding collapsed but then turning into visible is unnecessary when one can return Visibility::Collapsed or Visibility::Visible.
2020-02-14 12:52:58 -08:00
Pepe Rivera
d196909246
Rename icons to new format and update internals package (#1028)
* Rename asset files

* Add missing files

* Exclude references to assets that don't exist

* Update internals version
2020-02-12 14:35:28 -08:00
Pepe Rivera
f1482252ef
Allow rendering the graph on a background thread (#1014)
* Render on background thread

* More work

* variable fix

* Add comments
2020-02-04 15:02:42 -08:00
Pepe Rivera
6ca8f90021
Fix focus bug in graphing mode and other small changes (#938)
* Fix some bugs

* Style fixes from prev PR
2020-01-31 13:45:16 -08:00
Yair Aichenbaum
f2dbaad9b9
Always on top tool tip (#968)
* First implementation of KeyboardAccelerators for OnTop

* Changed shortcut keys to match the specs

* Adjusted ToolTips for compact overlay buttons to show the KeyboardAccelerator
2020-01-28 19:21:19 -08:00
Rudy Huyn
cdaf97e3d7
Update Calculator MDL2 Font(#972) 2020-01-28 10:05:38 -08:00
Pepe Rivera
ca0b3d83e8
fix bugs (#934) 2020-01-14 13:52:57 -08:00
Stephanie Anderl
9fc9c97ee7
Update KGF Back Button Styling (#927)
* Remove rounded corners on the back button

* Updated back button style to align with Equation button.

* Fixed issue where the forground color was white in high contrast and fixed the crash in high contrast
2020-01-13 15:09:45 -08:00
Pepe Rivera
3d1f0e9440
Make variable boxes collapsible on click (#916)
* fix

* PR comments

* fix bug

Co-authored-by: Eric Wong <eriwong@microsoft.com>
2020-01-13 10:08:23 -08:00
Scott Freeman
80e9b82bdc Removing useless code from VisualTree::FindDescendantByName (#925) 2020-01-10 18:06:21 -08:00
Eric Wong
c7c9bf0513
Use path instead of glyph for active tracing (#910)
* Use path instead of glyph
2020-01-10 16:42:55 -08:00
Pepe Rivera
240792a775 Adjustments to ghost textbox (#924)
* adjustments

* delete extra visual states

* Fix hover bug

* Fix a few more bugs

* Fix high contrast crash
2020-01-10 16:41:23 -08:00
Stephanie Anderl
ab2ad8cdee Update Font Sizes for Graph Settings and Key Graph Features to be aligned (#923)
* Updated fonts for Graph Settings to match KGF

* Update graph settings font sizes to be a bigger

* Update KGF fonts to match Graph Settings
2020-01-10 15:56:12 -08:00
Matt Cooley
6c524e68e2 Remove LimitedAccessFeatures check for old package name (#921) 2020-01-10 15:46:55 -08:00
Pepe Rivera
397c180d52 Format MathML equations before submission to the GraphControl (#926)
* Format richedit input

* fix spelling error
2020-01-10 15:17:36 -08:00
Pepe Rivera
c8a67eb574 ui changes (#920) 2020-01-09 14:10:48 -08:00
Rudy Huyn
9b9c9fb7ee
Fix function symbols in RtoL (#914) 2020-01-09 13:33:09 -08:00
Rudy Huyn
6fe229fc15 Update toggle to switch from graph to equations (#912)
* Modify toggle to switch from graph to equations

* support RtoL languages

* fix margin
2020-01-09 09:44:46 -08:00
Stephanie Anderl
c3414ea9c9
Change Calculator app name back to Calculator and add more margin to the preview tag for graphing mode (#909) 2020-01-08 14:56:44 -08:00
Rudy Huyn
f9c049a84b Add preview tag to Graphing feature (#907)
* Add preview tag to Graphing

* Fix Graph Settings button in dark mode
2020-01-08 10:34:05 -08:00
Eric Wong (PAX)
09926e4f84 Fix build as a result of merge conflict 2020-01-07 14:26:40 -08:00
Eric Wong (PAX)
aad968ff37 Merge remote-tracking branch 'upstream/master' into mergeFeature 2020-01-07 14:08:18 -08:00
Rudy Huyn
2d177e5160 CalcViewModel code cleaning (#754)
* move KeyboardShortcutManager, ValidationConverter and ViewState to Calculator
* remove dead code listed in #753
* remove Microsoft.UI.Xaml nuget package from CalcViewModel
2020-01-07 13:59:51 -08:00
Rudy Huyn
712bdb1b7c Code cleaning: Remove all properties/functions not used in CalculationResult (#649) 2020-01-07 11:03:47 -08:00
Rudy Huyn
7f2c300e37 remove the useless code related to the management of the focus in CalculationResult (#700) 2020-01-06 15:21:29 -08:00
Eric Wong (PAX)
78c6c2faff Fix filters from bad merge 2020-01-06 14:43:07 -08:00
Eric Wong (PAX)
d2b2853114 Merge remote-tracking branch 'upstream/feature/GraphingCalculator' into mergeFeature 2020-01-06 14:42:40 -08:00
Rudy Huyn
22f57aab3f Take windows setting into account to Disable/Enable animations (#748) 2020-01-06 14:36:45 -08:00
Pepe Rivera
3592b3d5a2 Update equation colors (#885) 2020-01-06 13:19:04 -08:00
Rudy Huyn
7aaeee934c Prevent the graph to pan/zoom in some cases (#897)
* prevent the graph to change ranges when hide/show an equation or change the trig unit

* make sure to not zoom/pan when we hide the last visible equation
2020-01-06 13:10:53 -08:00
Rudy Huyn
8357f5d5c5
Add Graph Settings (#879) 2020-01-03 15:06:14 -08:00
Eric Wong
234ac8deb3
Change active tracing to use correct glyph instead of dot (#890)
* Change active tracing to use correct glyph instead of dot

* make the pointer on the glyph line up correctly
2020-01-03 12:08:02 -08:00
Pepe Rivera
3b916dcec3 Minor changes to share output (#886)
* Make some tweaks to share output

* adjust strings

* one more tweak

* Remove unneeded span
2020-01-03 10:45:51 -08:00
dovisutu
4846190008 Update build year in Aboutflyout (#895) 2020-01-03 02:21:31 -08:00
Rudy Huyn
3942662c9d High Contrast support for Graphing Calculator (#878)
* Equation Control - High contrast

* tweak

* Update graph colors when users switch from one high contrast mode to another

* decrease opacity of reveal borders
2019-12-20 10:56:01 -08:00
Eric Wong
13e31799c9 Wire up keyboard in graphing calculator (#863)
* Wire up graphing calculator keyboard with math rich edit control

* CR feedback

* Handle focus bug in flyout
2019-12-19 09:56:03 -08:00
Rudy Huyn
38da8d7b38 support ctrl+- and + (#882) 2019-12-18 16:06:13 -08:00
Rudy Huyn
dc79ec65f6 Remove EquationTextBox from KeyGraphFeaturesPanel (#833)
* remove EquationBox from KFG

* polish

* improve templates

* fix issue with dark theme and MathRichEditBox
2019-12-16 23:00:06 -08:00
Rudy Huyn
fe599e31f8 Update graph tooltip design and content (#867)
* update graph tooltip

* modify font size
2019-12-16 10:41:35 -08:00
Rudy Huyn
eb2fa6db9b Fix focus issues (#868) 2019-12-16 10:13:34 -08:00
Rudy Huyn
dbddc7bc86 Save and restore the value of EquationInputArea when users scroll (#866)
* Save and restore the value of EquationInputArea when users scroll

* clean up

* replace ->Focus(..) by FocusManager::TryFocus(...)
2019-12-13 16:42:12 -08:00
Rudy Huyn
534139d67d GraphControl: refactoring and optimizations (#831)
* GraphControl cleaning

* replace textbox value after submission

* rebase

* rebase

* rebase

* Add filters

* rebase!

* rebase
2019-12-13 16:33:08 -08:00
Rudy Huyn
da38b5a015 Move variables to the right column (#859)
* move variable editor

* support high contrast and tab navigation

* Remove obsolete resources

* take feedback into account

* Fix focus when virtualization recycle a EquationTextBox

* formatting
2019-12-12 14:52:36 -08:00
Pepe Rivera
2a0637e51c
Fix some UI bugs in graph mode (#862)
* Address issues with error states

* Add various fixes

* Add back initial tooltip

* PR comments
2019-12-12 12:58:28 -08:00
Rudy Huyn
f282605bc6 Redesign graph buttons + replace ActiveTracing button by a ToggleButton (#864)
* redesign graph buttons

* fix high-contrast and focus
2019-12-12 09:38:10 -08:00
Stephanie Anderl
f593c621aa
Update GraphingCalculator Projects to allow official builds (#852)
* renamed MockGraphingImpl to GraphingImpl, updated the nuget.config to include the WindowsApps feed

* Revert nuget.config change

* Updated vcxproj files to output to the same directory regardless of configuration

* Removed outder used GenerateProjectSpecificOutputfolder instead

* revert commenting out the temporary.pfx cert in the calculator.vcxproj file
2019-12-10 16:15:49 -08:00
Rudy Huyn
07d012cf6b [Graph] Replace the Add button by a EquationTextBlock (#826)
* init

* Replace the Add equation button by an EquationTextBox

* Move automatically the focus to the next textbox when users press Enter

* nit

* localize the placeholder

* rebase

* rebased and disable remove context menu when the equation is the last one

* replace storyboards by setters in visual states
2019-12-10 11:06:37 -08:00
Eric Wong
4bb5c39e34
Add context menu to rich edit to allow for keyboard support (#854)
* Add context menu to rich edit to allow for keyboard support

* Update src/Calculator/Controls/EquationTextBox.cpp

Co-Authored-By: Pepe Rivera <joseartrivera@gmail.com>

* Check for focus before triggering submit
2019-12-09 13:18:06 -08:00
Pepe Rivera
c6d3132ad4 Add keyboard UI (#855) 2019-12-09 12:52:10 -08:00
Rudy Huyn
5209084bb0 Fix crash with x86 (#853) 2019-12-06 17:02:46 -08:00
Rudy Huyn
503831895d
Hide or Disable graphing calculator menu item when necessary (#848) 2019-12-06 15:03:07 -08:00
Eric Wong
36327b73de
Adding automation names to buttons (#842)
* Add missing automation names for buttons in graphing calculator

* Add narrator support for tracing features
2019-12-04 11:00:07 -08:00
Eric Wong
133df73d6a Add icons for show, hide and switch to equation mode (#845)
* Add icons for show, hide and switch to equation mode

* use correct icon for small mode

* cleanup of fonts
2019-12-03 16:02:46 -08:00
Pepe Rivera
89c3fc3e4d Add error handling to graph and equations (#827)
* add error handling

* Handle regraphing on certain errors

* Fix high contrast

* Hide KGF button in error state
2019-12-03 14:41:39 -08:00
Matt Cooley
3ca4f4ffa7
Change GraphingCalculator package identity back to WindowsCalculator.Dev (#843) 2019-12-03 13:59:10 -08:00
Matt Cooley
03c2d6514f
Build GraphingCalculator against SDK 18362 (#841) 2019-12-03 13:28:49 -08:00
Rudy Huyn
6911f2b268 Add missing brush 2019-12-02 20:22:21 -08:00
Rudy Huyn
73d6a32add merge with master 2019-12-02 19:36:54 -08:00
Rudy Huyn
f395d14764 Hide the Edit Variables button when no variables are available (#823) 2019-11-22 17:49:57 -08:00
Rudy Huyn
25d7a46ac1 Modify how we manage the visibility of the history button (#821)
* Modify how we manage the visibility of the history button

* rename function
2019-11-22 16:22:53 -08:00
Eric Wong
603d672015 Add tooltips to buttons in graphing calculator (#822)
* Add tooltips to buttons in graphing calculator

* Fix break due to bad merge

* CR Feedback
2019-11-22 15:08:23 -08:00
Rudy Huyn
7ef6eaf1b6 Added support for small windows in the graphing calculator (#803)
* Add support of small windows

* remove extra space

* Modify how we manage the tooltip

* Fix merge issues
2019-11-22 10:36:36 -08:00
Stephanie Anderl
a33c1a4494
Equation button updates: Enable/Disable on click, button content f1, f2, f3..., visibility icon on hover (#804)
* Added enable/disable line functionality

* Update EquationTextBox to change the opacity of functions have are not visible. Update the function label for the EquationTextBox to increment the label to show f1, f2, f3, etc

* rebase key-graph-features and fix issue where removing an equation box and adding a new one repopulates the previous equation

* Added visibility icon for the equation button hover

* updated EquationButton to be a toggle button to better handle the LineHidden state and other PR comment fixes.

* Updated EquationButton style to use a toggle button and to have placeholder icons for the show/hide states

* Updated equation button after pulling the refactor work into the branch. Fixed the Equation Button in KGF UI

* Fixed Pepe's bugs

* Uncomment temporary.pfx in calculator.vcxproj
2019-11-21 15:07:45 -08:00
Pepe Rivera
288a90e0fe
Refactor Equation to be treated as a model and update Key Graph Features (#791)
* refactor code

* update KGF

* Rename some functions

* Undo comment out of proj file

* Pr feedback
2019-11-20 14:28:32 -08:00
Pepe Rivera
9ee2f8a293
Update styles for buttons on Graph and ListView (#793)
* Fix listview

* extra merge with KGF

* Few tweaks

* Fix scrolling

* PR feedback and other tweaks

* Update src/Calculator/Views/GraphingCalculator/EquationInputArea.xaml

Co-Authored-By: Stephanie Anderl <46726333+sanderl@users.noreply.github.com>
2019-11-20 11:41:21 -08:00
Pepe Rivera
b55659f236 Update share output (#782)
* fix share bugs

* PR feedback

* PR feedback and merge fix

* Fix spacing and use explicit break

* Fix extra space
2019-11-19 15:54:24 -08:00
Rudy Huyn
1380c7ed83 Use only NumberBase to represent radix in CalcViewModel (#797) 2019-11-14 07:09:17 -08:00
Rudy Huyn
b9b0e068cd
Convert CopyPasteManager to runtime class (#766)
* Convert CopyPasteManager to runtime class
* merge AssertUtils and Helpers.h
* update onpastemanager
2019-11-13 15:15:13 -08:00
Pepe Rivera
afc1b2146c
Fix focus for EquationTextBox (#787) 2019-11-13 13:10:05 -08:00
Stephanie Anderl
442ed6a861
Key graph features (#704)
* Added IGraphAnalyzer

* Key Graph Features called and getting returned to the client. To do put all strings into the Equation object

* Updated UpdateKeyGraphFeatures to add function analysis data to all properties in Equation object

* Update KGF when variables are updated

* Key graph features ui started

* Added MathRichEditBox and started hooking up key graph features to the UI

* Updated EquationViewModel to include parity and periodicity

* Updated key graph features to update the EquationViewModel

* updated key graph features to display more values

* Key graph features populating uing MathRichEdit mode

* moved KeyGraphFeatures control to GraphingCalculator.xaml

* Use MathML formatting instead of MathRichEdit for strings passed back from the engine

* cleaned up project targeting and equation.h comments

* Updated equation edit box to populate for KeyGraphFeatures

* Fixed vcxproj files to have the correct targeting and certificates. KGF Title strings moved to x:Uid instead of the code behind

* Updated per PR feedback

* Update MathRichEditBox to detect if the string is a mathml string and use the appropriate set method to set the text

* fixed the issue where parity, periodicity and monotonicity could be set with an old value if the next one is empty

* KGF control UI adjustments and error handling

* Error control updates

* Error handling added when analysis fails

* fixed alignment on rich edit boxes

* Add monotonicity direction into the mathml string and only have 1 richeditbox

* Set hover state on KGF EquationEditBox to change button opacity and fixed spacing in Monotonicity RichEditBox

* remove sideload package certificate info VS added

* updated logic for setting error strings to be in the viewmodel

* Updated KeyGraphFeatures to populate dynamically using a ListView and TemplateSelector

* Update periodicity to not show if it isn't supported

* Fixed issue where y-intercept was using the x-intercept value

* Remove ItemsControl ItemsContainerStyle

* Updated per pr feedback. Fixed bug where analysis error would not reset

* Update MathRichEdit box to remove selection when focus is lost

* Updated mathrichedit to get LAF access for Dev, Release and Graphing projects

* Remove OnLostFocus in MathRichEdit, Change KGF ItemsControl back to ListView

* Clean up styles for KGF and ensure the match the comps

* Moved formatoptions logic to the Grapher constructor and reverted LineColor.Text resource that was mistakenly taken out

* Add copyright header to KGF Files

* fixed issue where asymptote values were not populating

* Disable KGF button when there is no equation. Fixed issue where equation populated in a new equationtextbox after the previous one was deleted

* Removed formatoptions testing lines used for debugging
2019-11-12 13:46:11 -08:00
Rudy Huyn
61c2d07a89 force a call to m_expressionContainer->Measure in UpdateScrollButtons (#750) 2019-11-11 16:23:30 -08:00
Rudy Huyn
5df3016df6 Fully separate Calculator and CalcManager (#752) 2019-11-06 15:31:57 -08:00
Rudy Huyn
577aafb3f4 Migrate TraceLogger to runtime class (#772) 2019-11-05 18:59:24 -08:00
Rudy Huyn
8ba7234550
Fix the right arrow button of CalculationResult not disappearing in some cases (#736) 2019-11-05 16:51:36 -08:00
Pepe Rivera
433d54d571
Fix crash and high contrast (#773) 2019-11-05 15:26:46 -08:00
Rudy Huyn
e38e911bfa Modify how Calculator manages the visibility of the History button (#712)
* Modify how Calculator manages the History button + code cleaning

* remove extra include
2019-11-05 15:04:28 -08:00