Commit Graph

750 Commits

Author SHA1 Message Date
Rudy Huyn
75fde82f46
Fix how we calculate the precision in Unit converter and update GetNumberDigitsWholeNumberPart (#1256)
* Fix 1255

* optimization

* spacing
2020-06-01 16:50:45 -07:00
Quentin Al-Timimi
60a7ee3604
Fixing TestHistoryClearCommand Test (#1253) 2020-06-01 07:18:08 -07:00
Quentin
178075d7d7
Setting IsEnabled to be conditional based on the AlwaysOnTop flag, (#1243) 2020-05-26 12:59:06 -05:00
Quentin
4fafc48a6f
Translations Patch for Preview Tag (#1247) 2020-05-26 11:51:56 -05:00
Stephanie Anderl
9a07755620
Fixed narrator issues in KGF and GraphView button, updated Trig radio button corner radius (#1227)
* fixed the trig units radio buttons rounded corners and narrator issues in kgf and graph reset

* removed extra whitespace

* Update src/Calculator/Resources/en-US/Resources.resw

Co-authored-by: Eric Wong <eriwong@microsoft.com>

* Update src/Calculator/Resources/en-US/Resources.resw

Co-authored-by: Eric Wong <eriwong@microsoft.com>

Co-authored-by: Eric Wong <eriwong@microsoft.com>
2020-05-26 09:34:45 -07:00
Rudy Huyn
143907f21f
Remove dead code from History (#1228)
* Clean history

* clean unit tests

* cleaning

* Remove friend class in HistoryViewModel
2020-05-25 15:02:27 -07:00
Rudy Huyn
c37f540265
Remove saved commands from CalculatorManager (#1230) 2020-05-25 10:43:31 -07:00
Eric Wong
79bd149b12
Handle non breaking white spaces in copy paste manager (#1226)
* Handle non breaking white spaces in copy paste manager

* handle other group characters
2020-05-21 14:08:16 -07:00
Quentin
4f03f995a2
Adding Preview tag to Resources File (#1239)
* Adding Preview tag to Resources File
2020-05-21 10:58:03 -05:00
Matt Cooley
6d122192d2
Check in localized strings 2020-05-15 (#1233) 2020-05-20 14:59:09 -07:00
Pepe Rivera
f2e423329d
Improve launch performance by delay loading NavigationView (#1213)
* Delay load graph engine

* Remove default behavior

* Delay load nav view

* Add automation properties

* clean up

* handle shortcut keys

* Include only navview changes

* Address PR comments

* manual merge fix

* PR Changes

* Undo other changes

* reset resw file

* fix margin
2020-05-19 09:58:11 -07:00
pi1024e
c1fefd3a7b
Change precision and variables regarding the number of digits to be unsigned instead of signed (#1092) 2020-05-18 20:14:40 -07:00
Matt Cooley
a69ee94663
Remove obsolete localization config file (#1236) 2020-05-18 18:18:44 -07:00
Matt Cooley
b4e850dc40
Remove more duplicate strings (#1235) 2020-05-16 12:16:54 -07:00
Matt Cooley
7f329f7729
Remove duplicate string for submit button automation name (#1234) 2020-05-16 10:48:38 -07:00
Rudy Huyn
80fbe891d6
Fix graph dark colors at launch (#1217) 2020-05-15 10:44:50 -07:00
Pepe Rivera
0f14e4f46e
Use ToggleButton for variable options chevron button (#1219)
* Use togglebutton instead

* Update src/Calculator/Views/GraphingCalculator/EquationInputArea.xaml

Co-authored-by: Rudy Huyn <rudyhuyn@gmail.com>

* Update src/Calculator/Views/GraphingCalculator/EquationInputArea.xaml

Co-authored-by: Rudy Huyn <rudyhuyn@gmail.com>

* undo pr suggestion

Co-authored-by: Rudy Huyn <rudyhuyn@gmail.com>
2020-05-13 18:42:35 -07:00
Rudy Huyn
7a6b0a72c3
Tweak UI: Title and History/Memory panels (#1215) 2020-05-11 16:38:45 -07:00
Pepe Rivera
1eda521992
fix style bugs in graph options (#1225) 2020-05-11 14:59:27 -07:00
Pepe Rivera
47760b4514
Don't submit equation when opening context menu (#1220)
* Don't submit equation when opening context menu

* Clean up
2020-05-08 18:50:22 -07:00
Pepe Rivera
66b64afd75
Fix styling bugs in graph settings and style panel (#1202) 2020-05-08 12:14:01 -07:00
Quentin
7b4ff49df8
Issue 935 - Updates to Scientific/Graphing Keypad (#1214)
* Switching from Difference between dates to Add or subtract dates ignores the first date field

https://github.com/microsoft/calculator/issues/254

Date field needs to persist across Date Difference and Add/Subtract From Date Mode.

* Update DateCalculator.xaml.cpp

Addressing review comments (white space, small code refactor), also found a null pointer exception during testing, this fix addresses that as well.

* Issue 935 - Updates to Scientific/Graphing Keypad

Update Scientific and Graphing keyboard layouts to expose square root button at the top level

* Updated ScientificModeFunctionalTests/SmokeTest_Cube()

Updated broken test to work with changes.
2020-05-08 12:32:17 -05:00
Eric Wong
e9c96c939a
Fix issues with sin being parsed incorrectly (#1199) 2020-05-08 10:31:02 -07:00
Stephanie Anderl
1e302cac58
Associate Units and Theme labels with the radio button groups (#1211)
* Wrap theme radio buttons in MUXC RadioButtons control to fix accessibility issue where the buttons are grouped with the theme title

* Associated theme labels with radio button groups
2020-05-07 16:41:08 -07:00
Stephanie Anderl
0105e6b319
Update tooltips for the Equation Button and Style Picker (#1163)
* Update EquationButton automation name and tooltips

* added tooltips to the stylepicker and fixed the issue where the color name did not update for dark mode colors

* Update src/Calculator/Resources/en-US/Resources.resw

Co-Authored-By: ItzLevvie <11600822+ItzLevvie@users.noreply.github.com>

* fixed the issue where the colors are only listed as black in the tooltip and automation name

* Add tooltips for high contrast colors

Co-authored-by: ItzLevvie <11600822+ItzLevvie@users.noreply.github.com>
2020-05-07 16:36:52 -07:00
Quentin
fd48f6ec1d
Switching from Difference between dates to Add or subtract dates ignores the first date field (#1210) 2020-05-06 15:14:54 -07:00
Matt Cooley
56760794dd
Update SignConfig.xml to use new signType (#1209) 2020-05-06 14:08:47 -07:00
Matt Cooley
f93c41a779
Logical_Operator_Decimal tests should ensure calculator is in decimal mode (#1208) 2020-05-05 15:08:29 -07:00
Stephanie Anderl
3055a12178
Updated EquationButton contrast fixed dark mode foreground color bugs (#1155)
* Fixed contrast between background and foreground colors in the equation button. Fixed the issue where the text in the equation text box is white when the background is white

* Adjust the foreground color algorithm

* moved the contrast method to utils so that it is resuable

* Moved brushes for the GetContrastColor method to the app.xaml resource dictionary

* Removed the change for the edit box colors, so it can be in a different PR
2020-05-05 10:20:05 -07:00
Pepe Rivera
9817738307
Catch exception when trying to share (#1203)
* Fix crash

* Fix errors
2020-05-05 09:36:09 -07:00
Eric Wong
f9a1ae1a28
Do not submit equations when in read only mode (#1201) 2020-05-05 08:46:40 -07:00
Pepe Rivera
264b5204d3
Update calculator version to 2004 (#1206)
* Update props file to 2004

* Update build/pipelines/azure-pipelines.release.yaml

Co-authored-by: ItzLevvie <11600822+ItzLevvie@users.noreply.github.com>

Co-authored-by: ItzLevvie <11600822+ItzLevvie@users.noreply.github.com>
2020-04-30 12:09:34 -07:00
Rudy Huyn
6e521d8f29
Remove LRE/LRO characters from results and error messages (#1161)
* Remove LRE/LRO characters and rely on Xaml to correctly displayed the numbers and error messages RtL

* unit tests
2020-04-30 12:04:33 -07:00
Daniel-Parker
2cafb0dc88
Scientific and Programmer tests (#779)
* Maximize window during setup, and added divide by zero error test

* Added Error_CubedNegativeNumber test and AOT buttons

* Made Added AoT Tests and test are faster

* Hotkey and Mouse Input BVT Test added, Memory Test started

* Started Aligning BVTs with manual tests.  Added TC23466694, TC17416429, and TC17416884, and a test to switching mode test

* Basic Scientific Mode Functional Test Tests

* Added history panel test, and history flyout test for Standard calculator, and added the supporting framework

* Added some functional tests for Scientific mode.

* Basic Scientific Mode functional tests, added solution to set Angle Operator button correctly.

* Created functions to resize the app to display history panel, to display history button, display memory panel, and memory button.  Then I applied them to reduce areas with rewritten code, and to help with over all test stability and speed.

* I added the trigonometry functional tests

* Pull from latetest master, and retargeted solution

* Added a GetCalculatorWindowPostion function, when resizing window to show history/memory label, set window position to (0,0), and the same when resizing KOT calculator.  This will make tests more stable by keeping calculator on screen. It will also help with any testing that may require tracking the apps postion. To fix a test failure, changed function from ResizeToDiplayHistoryButton to ResizeToNotDisplayHistoryLabel.

* Sorted Using Statements, modified .gitignore to ignore **src/out, etc...

* Merged CalcMemoryFlyout into MemoryPanel, and deleted CalcMemoryFlyout. Merged CalcHistoryFlyout in HistoryPanel, and deleted CalcMemory.  Created GlobalCalculatorUI.cs.  Updated tests to work with these changes.

* hold on to changes

* Changed all KOT to Aot,
Removed equal button click in Test Cleanup/History method uses page source,
Removed extra line in Calculator.vcxproj.filters, Removed Try/Catch in the ClearHistory method

* Removed unused elses
Added CalculatorResults class
Added StandardAoTCalculatorPage
Removed manual test case info in the comments

* - In test framework, where it worked,
made some elements private
- Created EnsureCalculatorHasFocus() in GlobalCalculatorUI.cs
- Due to new classes, moved some methods to more correct classes
- Moved "page.MemoryPanel.ResizeWindowToDiplayMemoryLabel();" from
SetupCalculatorSession() to ClassInitialize()

* Sorted Using

* Updating fork from latest master

* Don't stand so

* Minor edits, fixing things from PR comments

* Merging scientific and standard mode tests, minor merge conflict fixes

* Method work
- Created ResizeAoTWindowToDiplayInvertButton()
    - Applied to test method AoT_ErrorMessage()
- Added page.ScientificOperators.ResetFEButton(fEButtonState.Normal);
to TestIniT in ScientificModeFunctionalTests
- Fixed if statement in public void ResetFEButton(fEButtonState value)

* Added StandardOperatorsPanel and removed duplicated code

* Created tests for Programmer mode, fixed a typo that appeared in multiple locations

* Fixed clear entry not working in Scientific test

* This time I really fixed the problem with clear memory not being found every time

* Revert shared changes

* Rebased onto master and resolved conflicts

* Fixed the 15 second delay on every scientific mode test

* Greatly shortened bitflipkeypad test

Co-authored-by: Crystal Edwards (Insight Global Inc) <v-credwa@microsoft.com>
Co-authored-by: Crystal Edwards <45952655+v-credwa@users.noreply.github.com>
2020-04-28 10:54:55 -07:00
Stephanie Anderl
fcbea550c8
Fixed issue where Shortcuts were still enabled in Graphing Mode (#1196)
* Fixed DisableShortcuts to disable per the specfic view id and fixed the issue where honorshortcuts did not set the value properly

* Updated the condition to always set the honor shortcuts to false if disable shortcuts is true
2020-04-24 15:46:37 -07:00
Pepe Rivera
c2c92f4006
Set IsTextScaleFactorEnabled to true for HEX, DEC, OCT, BIN buttons (#1157)
* fix scale factor

* Allow expression to scale
2020-04-24 10:03:04 -07:00
Pepe Rivera
db86e949f9
Don't create a new flyout every time the graph settings button is clicked (#1197)
* attempt a fix

* fix ranges
2020-04-24 10:02:44 -07:00
Pepe Rivera
7fb341e9b2
Fix equation submitting twice when submitted via enter key (#1195) 2020-04-23 15:54:04 -07:00
Pepe Rivera
0465dc8538
Change trace point value precision to be dynamic based on graph scale (#1148)
* Dynamic precision

* add comments

* feedback

* Update src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp

Co-Authored-By: Rudy Huyn <rudyhuyn@gmail.com>

* PR feedback

* Pr comment

Co-authored-by: Rudy Huyn <rudyhuyn@gmail.com>
2020-04-21 17:44:08 -07:00
Stephanie Anderl
1ded2c57db
Fixed crash when in high contrast (#1159)
* Fixed line colors out of bounds issue when switching to high contrast

* Update the fix to not reload the colors OnColorChanged when in HighContrast
2020-04-15 12:42:31 -07:00
Pepe Rivera
15b957c98b
Fix line becoming enabled on focus lost (#1167) 2020-04-14 15:51:17 -07:00
Stephanie Anderl
3a8fcaa18a
Update Icons Implement the Graph View Button (#1149)
* Update icon file

* function analysis and negate button icons updated

* Replace zoom reset button with graph view button

* Fixed issue where the window settings did not update after panning/zooming

* Updated icon styling and added logic for updating the graph view button state when user manipulates the graph and when all equations are removed

* updated LogGraphButton clicked to have an enum for the button value instead of a string

* Updated the logic for how to set the IsManualAdjustment, ensured graphsettings now update IsManualAdjustment when changed
2020-04-14 12:37:23 -07:00
Stephanie Anderl
7612b69949
Add Automation Names to the GraphNumPad (#1145)
* Turn off keyboard shortcuts when in graphing mode

* Added automation names to the graphnumpad, added any missing ones to the resources.resw file

* Remove HonorShortcuts call in the EquationInputArea, update Equal button automation name to use the existing one

* conditionally set the HonorShortcuts when the nav menu is closed

* added disable shortcuts to override HonorShortcuts when it is set
2020-04-14 12:37:00 -07:00
Rudy Huyn
0318c8f359
Delay load GraphingNumPad::buttonOutput to not call localizationSettings too early (#1162) 2020-04-10 11:23:42 -07:00
Pepe Rivera
3a808b5022
Update styling of graph settings textbox and add shadow (#1079)
* Update internal package vers

* fix more bugs

* PR comments

* PR comments

* Undo last PR changes

* Pr comments
2020-04-09 16:58:18 -07:00
Pepe Rivera
0a01a10566
Recycle equation colors when no longer in use (#1154)
* Fix two pane crash on closing window

* recycle equation colors

* PR comments
2020-04-09 16:58:08 -07:00
Stephanie Anderl
33b4d18638
Add Automation Names to UI Elements in EquationInputArea and KGF Panel (#1133)
* Missing EquationInputArea and KGF Automation Names added

* Updated the KGF back button automation name and tooltip and added the automation name string for the KGF equation edit box

* Reverted the removal of x:names and updated Variable Step Textbox to Variable Step Value Textbox per PR feedback

* Updated the VariableListViewItem narrator announcement to include the name of the variable
2020-04-09 13:16:05 -07:00
Pepe Rivera
07108af967
Fix crash when using "C" key to clear equation (#1152)
* Fix two pane crash on closing window

* clearcrash
2020-04-09 12:24:25 -07:00
Rudy Huyn
a6ac3bbeae
CalculationResult: keep focus on Scroll buttons (#669) 2020-04-07 17:08:43 -07:00
Rudy Huyn
825b42ad46
refactor HistoryTest.cpp to test the history using HistoryViewModel (#784)
* refactor HistoryTest

* modify MultiWindowUnitTests to not use m_standardCalcManager

* rebase

Co-authored-by: Rudy Huyn <rudy.huyn@microsoft.com>
2020-04-07 17:08:02 -07:00