Modify how Calculator manages the visibility of the History button (#712)

* Modify how Calculator manages the History button + code cleaning

* remove extra include

src/CalcViewModel/CalcViewModel.vcxproj

@@ -354,7 +354,6 @@
     <ClInclude Include="StandardCalculatorViewModel.h" />
     <ClInclude Include="targetver.h" />
     <ClInclude Include="UnitConverterViewModel.h" />
-    <ClInclude Include="ViewState.h" />
   </ItemGroup>
   <ItemGroup>
     <ClCompile Include="ApplicationViewModel.cpp" />
@@ -395,7 +394,6 @@
     </ClCompile>
     <ClCompile Include="StandardCalculatorViewModel.cpp" />
     <ClCompile Include="UnitConverterViewModel.cpp" />
-    <ClCompile Include="ViewState.cpp" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\CalcManager\CalcManager.vcxproj">

src/CalcViewModel/CalcViewModel.vcxproj.filters

@@ -20,7 +20,6 @@
     <ClCompile Include="MemoryItemViewModel.cpp" />
     <ClCompile Include="StandardCalculatorViewModel.cpp" />
     <ClCompile Include="UnitConverterViewModel.cpp" />
-    <ClCompile Include="ViewState.cpp" />
     <ClCompile Include="Common\AppResourceProvider.cpp">
       <Filter>Common</Filter>
     </ClCompile>
@@ -95,7 +94,6 @@
     <ClInclude Include="MemoryItemViewModel.h" />
     <ClInclude Include="StandardCalculatorViewModel.h" />
     <ClInclude Include="UnitConverterViewModel.h" />
-    <ClInclude Include="ViewState.h" />
     <ClInclude Include="Common\AlwaysSelectedCollectionView.h">
       <Filter>Common</Filter>
     </ClInclude>
@@ -205,4 +203,7 @@
     </None>
     <None Include="packages.config" />
   </ItemGroup>
+  <ItemGroup>
+    <Page Include="$(MSBuildThisFileDirectory)DensityStyles\Compact.xaml" />
+  </ItemGroup>
 </Project>

src/CalcViewModel/Common/Utils.cpp

@@ -10,7 +10,6 @@
 #include "Common/AppResourceProvider.h"
 #include "Common/ExpressionCommandSerializer.h"
 #include "Common/ExpressionCommandDeserializer.h"
-#include "ViewState.h"
 
 using namespace CalculatorApp;
 using namespace CalculatorApp::Common;

src/CalcViewModel/ViewState.cpp

@@ -1,19 +0,0 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.
-// Licensed under the MIT License.
-
-#include "pch.h"
-#include "ViewState.h"
-
-namespace CalculatorApp
-{
-    namespace ViewState
-    {
-        Platform::StringReference Snap(L"Snap");
-        Platform::StringReference DockedView(L"DockedView");
-
-        bool IsValidViewState(Platform::String ^ viewState)
-        {
-            return viewState->Equals(ViewState::Snap) || viewState->Equals(ViewState::DockedView);
-        }
-    }
-}

src/CalcViewModel/ViewState.h

@@ -1,15 +0,0 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.
-// Licensed under the MIT License.
-
-#pragma once
-
-namespace CalculatorApp
-{
-    namespace ViewState
-    {
-        extern Platform::StringReference Snap;
-        extern Platform::StringReference DockedView;
-
-        bool IsValidViewState(Platform::String ^ viewState);
-    }
-}