DevWiki/calculator
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Added Input pasted event and added to all modes (#593)

Browse Source
This commit is contained in:
Stephanie Anderl 2019-07-18 11:21:35 -07:00 committed by GitHub
parent aea12015bd
commit bb027aa9c3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/CalcViewModel/Common/TraceLogger.cpp
View File

@ -33,6 +33,7 @@ namespace CalculatorApp
constexpr auto EVENT_NAME_MEMORY_ITEM_LOAD = L"MemoryItemLoad"; constexpr auto EVENT_NAME_MEMORY_ITEM_LOAD = L"MemoryItemLoad";
constexpr auto EVENT_NAME_VISUAL_STATE_CHANGED = L"VisualStateChanged"; constexpr auto EVENT_NAME_VISUAL_STATE_CHANGED = L"VisualStateChanged";
constexpr auto EVENT_NAME_CONVERTER_INPUT_RECEIVED = L"ConverterInputReceived"; constexpr auto EVENT_NAME_CONVERTER_INPUT_RECEIVED = L"ConverterInputReceived";
constexpr auto EVENT_NAME_INPUT_PASTED = L"InputPasted";
constexpr auto EVENT_NAME_EXCEPTION = L"Exception"; constexpr auto EVENT_NAME_EXCEPTION = L"Exception";
@ -369,4 +370,16 @@ namespace CalculatorApp
fields.AddUInt64(PDT_PRIVACY_DATA_TAG, PDT_PRODUCT_AND_SERVICE_USAGE); fields.AddUInt64(PDT_PRIVACY_DATA_TAG, PDT_PRODUCT_AND_SERVICE_USAGE);
LogLevel2Event(EVENT_NAME_NAV_BAR_OPENED, fields); LogLevel2Event(EVENT_NAME_NAV_BAR_OPENED, fields);
} }
void TraceLogger::LogInputPasted(ViewMode mode) const
{
if (!GetTraceLoggingProviderEnabled())
return;
LoggingFields fields{};
fields.AddGuid(L"SessionGuid", sessionGuid);
fields.AddString(L"Mode", NavCategory::GetFriendlyName(mode)->Data());
fields.AddUInt64(PDT_PRIVACY_DATA_TAG, PDT_PRODUCT_AND_SERVICE_USAGE);
LogLevel2Event(EVENT_NAME_INPUT_PASTED, fields);
}
} }

1
src/CalcViewModel/Common/TraceLogger.h
View File

@ -54,6 +54,7 @@ namespace CalculatorApp
void LogStandardException(CalculatorApp::Common::ViewMode mode, std::wstring_view functionName, _In_ const std::exception& e) const; void LogStandardException(CalculatorApp::Common::ViewMode mode, std::wstring_view functionName, _In_ const std::exception& e) const;
void LogWinRTException(CalculatorApp::Common::ViewMode mode, std::wstring_view functionName, _In_ winrt::hresult_error const& e) const; void LogWinRTException(CalculatorApp::Common::ViewMode mode, std::wstring_view functionName, _In_ winrt::hresult_error const& e) const;
void LogPlatformException(CalculatorApp::Common::ViewMode mode, std::wstring_view functionName, _In_ Platform::Exception ^ e) const; void LogPlatformException(CalculatorApp::Common::ViewMode mode, std::wstring_view functionName, _In_ Platform::Exception ^ e) const;
void LogInputPasted(CalculatorApp::Common::ViewMode mode) const;
private: private:
// Create an instance of TraceLogger // Create an instance of TraceLogger

1
src/CalcViewModel/StandardCalculatorViewModel.cpp
View File

@ -765,6 +765,7 @@ void StandardCalculatorViewModel::OnPaste(String ^ pastedString)
return; return;
} }
TraceLogger::GetInstance().LogInputPasted(GetCalculatorMode());
bool isFirstLegalChar = true; bool isFirstLegalChar = true;
m_standardCalculatorManager.SendCommand(Command::CommandCENTR); m_standardCalculatorManager.SendCommand(Command::CommandCENTR);
bool sendNegate = false; bool sendNegate = false;

1
src/CalcViewModel/UnitConverterViewModel.cpp
View File

@ -893,6 +893,7 @@ void UnitConverterViewModel::OnPaste(String ^ stringToPaste)
return; return;
} }
TraceLogger::GetInstance().LogInputPasted(Mode);
bool isFirstLegalChar = true; bool isFirstLegalChar = true;
bool sendNegate = false; bool sendNegate = false;
wstring accumulation = L""; wstring accumulation = L"";