DevWiki/calculator
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove calcmanager ref (#9)

Browse Source 
Calculator (the main app project) depends on CalcManager, but only transitively: Calculator -> CalcViewModel -> CalcManager.

However, Calculator's project file currently has a direct dependency on CalcManager. Let's remove this to make it harder to accidentally introduce new dependencies between the layers.

Also cleaning up some commented-out directives in the CalcManager MSBuild file.
This commit is contained in:
Matt Cooley 2019-02-04 11:53:02 -08:00 committed by GitHub
parent 177a606012
commit ac63c1e1c2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/CalcManager/CalcManager.vcxproj
View File

@ -315,9 +315,6 @@
<ClCompile Include="Ratpack\support.cpp" />
<ClCompile Include="Ratpack\trans.cpp" />
<ClCompile Include="Ratpack\transh.cpp" />
<!-- <ClCompile Include="Source Files\CalculatorController.cpp" />
<ClCompile Include="Source Files\CalculatorHistory.Cpp" />
<ClCompile Include="Source Files\CalculatorManager.cpp" /> -->
<ClCompile Include="pch.cpp">
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">Create</PrecompiledHeader>
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">Create</PrecompiledHeader>

3
src/Calculator/Calculator.vcxproj
View File

@ -813,9 +813,6 @@
</Font>
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\CalcManager\CalcManager.vcxproj">
<Project>{311e866d-8b93-4609-a691-265941fee101}</Project>
</ProjectReference>
<ProjectReference Include="..\CalcViewModel\CalcViewModel.vcxproj">
<Project>{90e9761d-9262-4773-942d-caeae75d7140}</Project>
</ProjectReference>