DevWiki/calculator
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Propose code-cleanups#2 (#253)

Browse Source 
Description of the changes:

Remove redundancy
Simplify if statements
This commit is contained in:
Shamkhal Maharramov 2019-03-21 01:28:30 +04:00 committed by Howard Wolosky
parent 683b91aeec
commit 251ffffc50
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/CalcManager/CalculatorHistory.cpp
View File

@ -34,15 +34,13 @@ unsigned int CalculatorHistory::AddToHistory(_In_ shared_ptr<CalculatorVector <p
unsigned int CalculatorHistory::AddItem(_In_ shared_ptr<HISTORYITEM> const &spHistoryItem) unsigned int CalculatorHistory::AddItem(_In_ shared_ptr<HISTORYITEM> const &spHistoryItem)
{ {
int lastIndex;
if (m_historyItems.size() >= m_maxHistorySize) if (m_historyItems.size() >= m_maxHistorySize)
{ {
m_historyItems.erase(m_historyItems.begin()); m_historyItems.erase(m_historyItems.begin());
} }
m_historyItems.push_back(spHistoryItem); m_historyItems.push_back(spHistoryItem);
lastIndex = static_cast<unsigned>(m_historyItems.size() - 1); unsigned int lastIndex = static_cast<unsigned>(m_historyItems.size() - 1);
return lastIndex; return lastIndex;
} }

4
src/CalcManager/CalculatorManager.cpp
View File

@ -1,4 +1,4 @@
// Copyright (c) Microsoft Corporation. All rights reserved. // Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. // Licensed under the MIT License.
#include "pch.h" #include "pch.h"
@ -360,7 +360,7 @@ namespace CalculationManager
/// <param name = "serializedPrimaryDisplay">Serialized Rational of primary display</param> /// <param name = "serializedPrimaryDisplay">Serialized Rational of primary display</param>
void CalculatorManager::DeSerializePrimaryDisplay(const vector<long> &serializedPrimaryDisplay) void CalculatorManager::DeSerializePrimaryDisplay(const vector<long> &serializedPrimaryDisplay)
{ {
if (serializedPrimaryDisplay.size() == 0) if (serializedPrimaryDisplay.empty())
{ {
return; return;
} }