DevWiki/calculator
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

No need to make an enum variable if it is either one of two possibilities. (#1036)

Browse Source 
Visibility variable holding collapsed but then turning into visible is unnecessary when one can return Visibility::Collapsed or Visibility::Visible.
This commit is contained in:
pi1024e 2020-02-14 15:52:58 -05:00 committed by GitHub
parent d8fedaffde
commit 1ecf431ea3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Calculator/Converters/VisibilityNegationConverter.cpp
View File

@ -16,12 +16,11 @@ namespace CalculatorApp
Object ^ VisibilityNegationConverter::Convert(Object ^ value, TypeName /*targetType*/, Object ^ /*parameter*/, String ^ /*language*/) Object ^ VisibilityNegationConverter::Convert(Object ^ value, TypeName /*targetType*/, Object ^ /*parameter*/, String ^ /*language*/)
{ {
auto boxedVisibility = dynamic_cast<Box<Visibility> ^>(value); auto boxedVisibility = dynamic_cast<Box<Visibility> ^>(value);
Visibility visibility = Visibility::Collapsed;
if (boxedVisibility != nullptr && boxedVisibility->Value == Visibility::Collapsed) if (boxedVisibility != nullptr && boxedVisibility->Value == Visibility::Collapsed)
{ {
visibility = Visibility::Visible; return Visibility::Visible;
} }
return visibility; return Visibility::Collapsed;
} }
Object ^ VisibilityNegationConverter::ConvertBack(Object ^ value, TypeName targetType, Object ^ parameter, String ^ language) Object ^ VisibilityNegationConverter::ConvertBack(Object ^ value, TypeName targetType, Object ^ parameter, String ^ language)