DevWiki/calculator
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
25399c75d9
calculator/src/CalcManager/ExpressionCommand.h

87 lines
2.8 KiB
C
Raw Normal View History

Return to initialization pattern in ExpressionCommand
2019-01-29 11:34:36 +08:00
// Copyright (c) Microsoft Corporation. All rights reserved.
Hello GitHub
2019-01-29 08:24:37 +08:00
// Licensed under the MIT License.
#pragma once
#include "ExpressionCommandInterface.h"
Convert ExpressionCommand and History collector to use Rational instead of PRAT
2019-01-29 11:14:15 +08:00
#include "Header Files/CalcEngine.h"
#include "Header Files/Rational.h"
Hello GitHub
2019-01-29 08:24:37 +08:00
Mark classes as `final` where applicable (#189)
2019-03-08 11:46:53 +08:00
class CParentheses final : public IParenthesisCommand
Hello GitHub
2019-01-29 08:24:37 +08:00
{
public:
CParentheses(_In_ int command);
Add `override` keyword where applicable (#188)
2019-03-09 03:18:01 +08:00
int GetCommand() const override;
CalculationManager::CommandType GetCommandType() const override;
Fix the project code style, as it is not consistent. (#236) Fixes #202 This PR fixes code style for the project files. The Problem Different files in the project use different code style. That is not consistent and leads to harder maintenance of the project. Description of the changes: Have investigated and determined the most used code style across the given codebase Have configured IDE and applied code style to all project files. Have crafted clang-formatter config. see https://clang.llvm.org/docs/ClangFormat.html https://clang.llvm.org/docs/ClangFormatStyleOptions.html Some cases were fixed manually How changes were validated: manual/ad-hoc testing, automated testing All tests pass as before because these are only code style changes. Additional Please review, and let me know if I have any mistake in the code style. In case of any mistake, I will change the configuration and re-apply it to the project.
2019-05-03 02:59:19 +08:00
void Accept(_In_ ISerializeCommandVisitor& commandVisitor) override;
Hello GitHub
2019-01-29 08:24:37 +08:00
private:
int m_command;
};
Mark classes as `final` where applicable (#189)
2019-03-08 11:46:53 +08:00
class CUnaryCommand final : public IUnaryCommand
Hello GitHub
2019-01-29 08:24:37 +08:00
{
public:
CUnaryCommand(int command);
CUnaryCommand(int command1, int command2);
Replacing CalculatorVector usage with std::vector (#756) * Replacing CalculatorVector usage with std::vector Assumptions made here are that memory allocations are not recoverable. If it can be proved that an index will be in range, then the indexing operation is used. If not (without manual checks) the std::vector::at function is used to throw an exception in case of a programmer bug. * Changes based on PR feedback Using auto& in CalculatorCollector::UpdateHistoryExpression so the token.first value is properly updated. Using range for loop to GenerateExpressions. Setting isEditable directly to the result of boolean expression. Using token.second directly instead of creating a separate tokenCommandIndex variable. * Fixing issue with generating expressions strings. A space should not be added before the first item.
2019-10-31 01:55:13 +08:00
const std::shared_ptr<std::vector<int>>& GetCommands() const override;
Add `override` keyword where applicable (#188)
2019-03-09 03:18:01 +08:00
CalculationManager::CommandType GetCommandType() const override;
void SetCommand(int command) override;
void SetCommands(int command1, int command2) override;
Fix the project code style, as it is not consistent. (#236) Fixes #202 This PR fixes code style for the project files. The Problem Different files in the project use different code style. That is not consistent and leads to harder maintenance of the project. Description of the changes: Have investigated and determined the most used code style across the given codebase Have configured IDE and applied code style to all project files. Have crafted clang-formatter config. see https://clang.llvm.org/docs/ClangFormat.html https://clang.llvm.org/docs/ClangFormatStyleOptions.html Some cases were fixed manually How changes were validated: manual/ad-hoc testing, automated testing All tests pass as before because these are only code style changes. Additional Please review, and let me know if I have any mistake in the code style. In case of any mistake, I will change the configuration and re-apply it to the project.
2019-05-03 02:59:19 +08:00
void Accept(_In_ ISerializeCommandVisitor& commandVisitor) override;
Hello GitHub
2019-01-29 08:24:37 +08:00
private:
Replacing CalculatorVector usage with std::vector (#756) * Replacing CalculatorVector usage with std::vector Assumptions made here are that memory allocations are not recoverable. If it can be proved that an index will be in range, then the indexing operation is used. If not (without manual checks) the std::vector::at function is used to throw an exception in case of a programmer bug. * Changes based on PR feedback Using auto& in CalculatorCollector::UpdateHistoryExpression so the token.first value is properly updated. Using range for loop to GenerateExpressions. Setting isEditable directly to the result of boolean expression. Using token.second directly instead of creating a separate tokenCommandIndex variable. * Fixing issue with generating expressions strings. A space should not be added before the first item.
2019-10-31 01:55:13 +08:00
std::shared_ptr<std::vector<int>> m_command;
Hello GitHub
2019-01-29 08:24:37 +08:00
};
Mark classes as `final` where applicable (#189)
2019-03-08 11:46:53 +08:00
class CBinaryCommand final : public IBinaryCommand
Hello GitHub
2019-01-29 08:24:37 +08:00
{
public:
CBinaryCommand(int command);
Add `override` keyword where applicable (#188)
2019-03-09 03:18:01 +08:00
void SetCommand(int command) override;
int GetCommand() const override;
CalculationManager::CommandType GetCommandType() const override;
Fix the project code style, as it is not consistent. (#236) Fixes #202 This PR fixes code style for the project files. The Problem Different files in the project use different code style. That is not consistent and leads to harder maintenance of the project. Description of the changes: Have investigated and determined the most used code style across the given codebase Have configured IDE and applied code style to all project files. Have crafted clang-formatter config. see https://clang.llvm.org/docs/ClangFormat.html https://clang.llvm.org/docs/ClangFormatStyleOptions.html Some cases were fixed manually How changes were validated: manual/ad-hoc testing, automated testing All tests pass as before because these are only code style changes. Additional Please review, and let me know if I have any mistake in the code style. In case of any mistake, I will change the configuration and re-apply it to the project.
2019-05-03 02:59:19 +08:00
void Accept(_In_ ISerializeCommandVisitor& commandVisitor) override;
Hello GitHub
2019-01-29 08:24:37 +08:00
private:
int m_command;
};
Mark classes as `final` where applicable (#189)
2019-03-08 11:46:53 +08:00
class COpndCommand final : public IOpndCommand
Hello GitHub
2019-01-29 08:24:37 +08:00
{
public:
Replacing CalculatorVector usage with std::vector (#756) * Replacing CalculatorVector usage with std::vector Assumptions made here are that memory allocations are not recoverable. If it can be proved that an index will be in range, then the indexing operation is used. If not (without manual checks) the std::vector::at function is used to throw an exception in case of a programmer bug. * Changes based on PR feedback Using auto& in CalculatorCollector::UpdateHistoryExpression so the token.first value is properly updated. Using range for loop to GenerateExpressions. Setting isEditable directly to the result of boolean expression. Using token.second directly instead of creating a separate tokenCommandIndex variable. * Fixing issue with generating expressions strings. A space should not be added before the first item.
2019-10-31 01:55:13 +08:00
COpndCommand(std::shared_ptr<std::vector<int>> const& commands, bool fNegative, bool fDecimal, bool fSciFmt);
Return to initialization pattern in ExpressionCommand
2019-01-29 11:34:36 +08:00
void Initialize(CalcEngine::Rational const& rat);
Hello GitHub
2019-01-29 08:24:37 +08:00
Replacing CalculatorVector usage with std::vector (#756) * Replacing CalculatorVector usage with std::vector Assumptions made here are that memory allocations are not recoverable. If it can be proved that an index will be in range, then the indexing operation is used. If not (without manual checks) the std::vector::at function is used to throw an exception in case of a programmer bug. * Changes based on PR feedback Using auto& in CalculatorCollector::UpdateHistoryExpression so the token.first value is properly updated. Using range for loop to GenerateExpressions. Setting isEditable directly to the result of boolean expression. Using token.second directly instead of creating a separate tokenCommandIndex variable. * Fixing issue with generating expressions strings. A space should not be added before the first item.
2019-10-31 01:55:13 +08:00
const std::shared_ptr<std::vector<int>>& GetCommands() const override;
void SetCommands(std::shared_ptr<std::vector<int>> const& commands) override;
Add `override` keyword where applicable (#188)
2019-03-09 03:18:01 +08:00
void AppendCommand(int command) override;
void ToggleSign() override;
void RemoveFromEnd() override;
bool IsNegative() const override;
bool IsSciFmt() const override;
bool IsDecimalPresent() const override;
Fix the project code style, as it is not consistent. (#236) Fixes #202 This PR fixes code style for the project files. The Problem Different files in the project use different code style. That is not consistent and leads to harder maintenance of the project. Description of the changes: Have investigated and determined the most used code style across the given codebase Have configured IDE and applied code style to all project files. Have crafted clang-formatter config. see https://clang.llvm.org/docs/ClangFormat.html https://clang.llvm.org/docs/ClangFormatStyleOptions.html Some cases were fixed manually How changes were validated: manual/ad-hoc testing, automated testing All tests pass as before because these are only code style changes. Additional Please review, and let me know if I have any mistake in the code style. In case of any mistake, I will change the configuration and re-apply it to the project.
2019-05-03 02:59:19 +08:00
const std::wstring& GetToken(wchar_t decimalSymbol) override;
Add `override` keyword where applicable (#188)
2019-03-09 03:18:01 +08:00
CalculationManager::CommandType GetCommandType() const override;
Fix the project code style, as it is not consistent. (#236) Fixes #202 This PR fixes code style for the project files. The Problem Different files in the project use different code style. That is not consistent and leads to harder maintenance of the project. Description of the changes: Have investigated and determined the most used code style across the given codebase Have configured IDE and applied code style to all project files. Have crafted clang-formatter config. see https://clang.llvm.org/docs/ClangFormat.html https://clang.llvm.org/docs/ClangFormatStyleOptions.html Some cases were fixed manually How changes were validated: manual/ad-hoc testing, automated testing All tests pass as before because these are only code style changes. Additional Please review, and let me know if I have any mistake in the code style. In case of any mistake, I will change the configuration and re-apply it to the project.
2019-05-03 02:59:19 +08:00
void Accept(_In_ ISerializeCommandVisitor& commandVisitor) override;
Build with /W4 (#197) All projects are built with warning level 4 (/W4) and treat warnings as errors (/WX). Fixed build errors resulting from enabling these compiler flags.
2019-03-09 15:15:28 +08:00
std::wstring GetString(uint32_t radix, int32_t precision);
Hello GitHub
2019-01-29 08:24:37 +08:00
private:
Replacing CalculatorVector usage with std::vector (#756) * Replacing CalculatorVector usage with std::vector Assumptions made here are that memory allocations are not recoverable. If it can be proved that an index will be in range, then the indexing operation is used. If not (without manual checks) the std::vector::at function is used to throw an exception in case of a programmer bug. * Changes based on PR feedback Using auto& in CalculatorCollector::UpdateHistoryExpression so the token.first value is properly updated. Using range for loop to GenerateExpressions. Setting isEditable directly to the result of boolean expression. Using token.second directly instead of creating a separate tokenCommandIndex variable. * Fixing issue with generating expressions strings. A space should not be added before the first item.
2019-10-31 01:55:13 +08:00
std::shared_ptr<std::vector<int>> m_commands;
Hello GitHub
2019-01-29 08:24:37 +08:00
bool m_fNegative;
bool m_fSciFmt;
bool m_fDecimal;
Return to initialization pattern in ExpressionCommand
2019-01-29 11:34:36 +08:00
bool m_fInitialized;
Hello GitHub
2019-01-29 08:24:37 +08:00
std::wstring m_token;
Convert ExpressionCommand and History collector to use Rational instead of PRAT
2019-01-29 11:14:15 +08:00
CalcEngine::Rational m_value;
Hello GitHub
2019-01-29 08:24:37 +08:00
void ClearAllAndAppendCommand(CalculationManager::Command command);
};
class ISerializeCommandVisitor
{
public:
Fix the project code style, as it is not consistent. (#236) Fixes #202 This PR fixes code style for the project files. The Problem Different files in the project use different code style. That is not consistent and leads to harder maintenance of the project. Description of the changes: Have investigated and determined the most used code style across the given codebase Have configured IDE and applied code style to all project files. Have crafted clang-formatter config. see https://clang.llvm.org/docs/ClangFormat.html https://clang.llvm.org/docs/ClangFormatStyleOptions.html Some cases were fixed manually How changes were validated: manual/ad-hoc testing, automated testing All tests pass as before because these are only code style changes. Additional Please review, and let me know if I have any mistake in the code style. In case of any mistake, I will change the configuration and re-apply it to the project.
2019-05-03 02:59:19 +08:00
virtual void Visit(_In_ COpndCommand& opndCmd) = 0;
virtual void Visit(_In_ CUnaryCommand& unaryCmd) = 0;
virtual void Visit(_In_ CBinaryCommand& binaryCmd) = 0;
virtual void Visit(_In_ CParentheses& paraCmd) = 0;
Hello GitHub
2019-01-29 08:24:37 +08:00
};
Reference in New Issue Copy Permalink