From febe73ff16584578e3818bc35b5a3350ab672f77 Mon Sep 17 00:00:00 2001 From: Ian Kasprzak Date: Tue, 19 Jan 2021 09:04:28 -0800 Subject: [PATCH] Update "evt" field to be logged as a string type. Testing: - Unit tests - Verified git trace log has "evt": "2" (vs "evt": 2 previously) Bug: https://crbug.com/gerrit/13966 Change-Id: I2e0c98dda0cccdd5cb6328105c11b93cd42676eb Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/294123 Reviewed-by: Jonathan Nieder Tested-by: Ian Kasprzak --- git_trace2_event_log.py | 2 +- tests/test_git_trace2_event_log.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/git_trace2_event_log.py b/git_trace2_event_log.py index dfbded1..fe34092 100644 --- a/git_trace2_event_log.py +++ b/git_trace2_event_log.py @@ -92,7 +92,7 @@ class EventLog(object): def _AddVersionEvent(self): """Adds a 'version' event at the beginning of current log.""" version_event = self._CreateEventDict('version') - version_event['evt'] = 2 + version_event['evt'] = "2" version_event['exe'] = RepoSourceVersion() self._log.insert(0, version_event) diff --git a/tests/test_git_trace2_event_log.py b/tests/test_git_trace2_event_log.py index 686802e..8fb38db 100644 --- a/tests/test_git_trace2_event_log.py +++ b/tests/test_git_trace2_event_log.py @@ -95,6 +95,8 @@ class EventLogTestCase(unittest.TestCase): # Check for 'version' event specific fields. self.assertIn('evt', version_event) self.assertIn('exe', version_event) + # Verify "evt" version field is a string. + self.assertIsInstance(version_event['evt'], str) def test_start_event(self): """Test and validate 'start' event data is valid.