From dc1b59d2c0a7ee00b7e6b111285360c4cff32d2b Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Mon, 30 Sep 2019 23:47:03 -0400 Subject: [PATCH] forall: exit 1 if we skip any repos If a repo doesn't exist (e.g. an incomplete sync), make sure we exit non-zero when they get skipped. Change-Id: Ifff711e374416b1e6b9b8da4fdc6f14b27ced450 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/239235 Reviewed-by: David Pursehouse Tested-by: Mike Frysinger --- subcmds/forall.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/subcmds/forall.py b/subcmds/forall.py index 0be8d3b..c9de26b 100644 --- a/subcmds/forall.py +++ b/subcmds/forall.py @@ -323,10 +323,10 @@ def DoWork(project, mirror, opt, cmd, shell, cnt, config): cwd = project['worktree'] if not os.path.exists(cwd): - if (opt.project_header and opt.verbose) \ - or not opt.project_header: + if ((opt.project_header and opt.verbose) + or not opt.project_header): print('skipping %s/' % project['relpath'], file=sys.stderr) - return + return 1 if opt.project_header: stdin = subprocess.PIPE