From 655aedd7f34d9f2ff6dd3cb77c080addd0f06c4b Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Tue, 4 Feb 2020 00:02:18 -0500 Subject: [PATCH] repo: raise min version of git The git-2.10 series was released in 2016. Since we're moving to require Python 3.6 which was also released in 2016, bumping up the git version seems reasonable. Also we don't really test any git versions close to as old as 1.7.2 which was released in 2010. Change-Id: Ib71b714de6cd0b7dd50d0b300b108a560ee27331 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/253134 Tested-by: Mike Frysinger Reviewed-by: David Pursehouse --- git_command.py | 3 ++- repo | 2 +- tests/test_git_command.py | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/git_command.py b/git_command.py index dc542c3..5017ea9 100644 --- a/git_command.py +++ b/git_command.py @@ -28,7 +28,8 @@ from repo_trace import REPO_TRACE, IsTrace, Trace from wrapper import Wrapper GIT = 'git' -MIN_GIT_VERSION = (1, 5, 4) +# Should keep in sync with the "repo" launcher file. +MIN_GIT_VERSION = (2, 10, 2) GIT_DIR = 'GIT_DIR' LAST_GITDIR = None diff --git a/repo b/repo index d6ce48e..0b87073 100755 --- a/repo +++ b/repo @@ -86,7 +86,7 @@ TACbBS+Up3RpfYVfd63c1cDdlru13pQAn3NQy/SN858MkxN+zym86UBgOad2 """ GIT = 'git' # our git command -MIN_GIT_VERSION = (1, 7, 2) # minimum supported git version +MIN_GIT_VERSION = (2, 10, 2) # minimum supported git version repodir = '.repo' # name of repo's private directory S_repo = 'repo' # special repo repository S_manifests = 'manifests' # special manifest repository diff --git a/tests/test_git_command.py b/tests/test_git_command.py index 51171a3..8d9b5f0 100644 --- a/tests/test_git_command.py +++ b/tests/test_git_command.py @@ -35,7 +35,7 @@ class GitCallUnitTest(unittest.TestCase): # We don't dive too deep into the values here to avoid having to update # whenever git versions change. We do check relative to this min version # as this is what `repo` itself requires via MIN_GIT_VERSION. - MIN_GIT_VERSION = (1, 7, 2) + MIN_GIT_VERSION = (2, 10, 2) self.assertTrue(isinstance(ver.major, int)) self.assertTrue(isinstance(ver.minor, int)) self.assertTrue(isinstance(ver.micro, int))