diff --git a/build/pipelines/templates/build-app-internal.yaml b/build/pipelines/templates/build-app-internal.yaml index 659b670..9dc0d42 100644 --- a/build/pipelines/templates/build-app-internal.yaml +++ b/build/pipelines/templates/build-app-internal.yaml @@ -12,7 +12,7 @@ jobs: displayName: Build ${{ parameters.platform }} condition: ${{ parameters.condition }} pool: - vmImage: vs2017-win2016 + vmImage: windows-2019 variables: BuildConfiguration: Release BuildPlatform: ${{ parameters.platform }} diff --git a/build/pipelines/templates/build-app-public.yaml b/build/pipelines/templates/build-app-public.yaml index 78c033e..c256e74 100644 --- a/build/pipelines/templates/build-app-public.yaml +++ b/build/pipelines/templates/build-app-public.yaml @@ -10,7 +10,7 @@ jobs: displayName: Build ${{ parameters.platform }} condition: ${{ parameters.condition }} pool: - vmImage: vs2017-win2016 + vmImage: windows-2019 variables: BuildConfiguration: Release BuildPlatform: ${{ parameters.platform }} diff --git a/build/pipelines/templates/build-single-architecture.yaml b/build/pipelines/templates/build-single-architecture.yaml index 50859db..a3e1d46 100644 --- a/build/pipelines/templates/build-single-architecture.yaml +++ b/build/pipelines/templates/build-single-architecture.yaml @@ -6,9 +6,9 @@ parameters: steps: - task: NuGetToolInstaller@0 - displayName: Use NuGet 4.7.1 + displayName: Use NuGet 5.0.2 inputs: - versionSpec: 4.7.1 + versionSpec: 5.0.2 checkLatest: true # In most accounts, you can just use 'NuGetCommand' instead of this GUID. @@ -29,7 +29,7 @@ steps: displayName: 'Build solution src/Calculator.sln' inputs: solution: src/Calculator.sln - vsVersion: 15.0 + vsVersion: 16.0 msbuildArgs: /bl:$(Build.BinariesDirectory)\$(BuildConfiguration)\$(BuildPlatform)\Calculator.binlog /p:OutDir=$(Build.BinariesDirectory)\$(BuildConfiguration)\$(BuildPlatform)\ /p:GenerateProjectSpecificOutputFolder=true /p:AppVersion=$(Build.BuildNumber) /t:Publish /p:PublishDir=$(Build.BinariesDirectory)\$(BuildConfiguration)\$(BuildPlatform)\publish\ ${{ parameters.extraMsBuildArgs }} platform: $(BuildPlatform) configuration: $(BuildConfiguration) diff --git a/build/pipelines/templates/package-appxbundle.yaml b/build/pipelines/templates/package-appxbundle.yaml index c773575..f88f155 100644 --- a/build/pipelines/templates/package-appxbundle.yaml +++ b/build/pipelines/templates/package-appxbundle.yaml @@ -17,7 +17,7 @@ jobs: in(dependencies.BuildARM64.result, 'Succeeded', 'SucceededWithIssues', 'Skipped') ) pool: - vmImage: vs2017-win2016 + vmImage: windows-2019 workspace: clean: outputs variables: diff --git a/docs/Images/VSInstallationScreenshot.png b/docs/Images/VSInstallationScreenshot.png index 3015269..d027e1b 100644 Binary files a/docs/Images/VSInstallationScreenshot.png and b/docs/Images/VSInstallationScreenshot.png differ diff --git a/src/CalcManager/CalcManager.vcxproj b/src/CalcManager/CalcManager.vcxproj index ed7a349..b1d4b40 100644 --- a/src/CalcManager/CalcManager.vcxproj +++ b/src/CalcManager/CalcManager.vcxproj @@ -56,46 +56,46 @@ StaticLibrary true - v141 + v142 StaticLibrary true - v141 + v142 StaticLibrary true - v141 + v142 StaticLibrary true - v141 + v142 StaticLibrary false true - v141 + v142 StaticLibrary false true - v141 + v142 StaticLibrary false true - v141 + v142 StaticLibrary false true - v141 + v142 diff --git a/src/CalcViewModel/CalcViewModel.vcxproj b/src/CalcViewModel/CalcViewModel.vcxproj index c5ed5af..9a8d133 100644 --- a/src/CalcViewModel/CalcViewModel.vcxproj +++ b/src/CalcViewModel/CalcViewModel.vcxproj @@ -50,46 +50,46 @@ StaticLibrary true - v141 + v142 StaticLibrary true - v141 + v142 StaticLibrary true - v141 + v142 StaticLibrary true - v141 + v142 StaticLibrary false true - v141 + v142 StaticLibrary false true - v141 + v142 StaticLibrary false true - v141 + v142 StaticLibrary false true - v141 + v142 @@ -414,16 +414,16 @@ - - - - - - - - - - + + + + + + + + + + diff --git a/src/CalcViewModel/Common/Utils.cpp b/src/CalcViewModel/Common/Utils.cpp index 8ad6081..89dd1e9 100644 --- a/src/CalcViewModel/Common/Utils.cpp +++ b/src/CalcViewModel/Common/Utils.cpp @@ -50,8 +50,7 @@ double Utils::GetDoubleFromWstring(wstring input) { wchar_t unWantedChars[] = { L' ', L',', 8234, 8235, 8236, 8237 }; wstring ws = RemoveUnwantedCharsFromWstring(input, unWantedChars, 6); - string inputString(ws.begin(), ws.end()); - return ::atof(inputString.c_str()); + return stod(ws); } // Returns windowId for the current view diff --git a/src/Calculator.sln b/src/Calculator.sln index 43a46f9..aef0d88 100644 --- a/src/Calculator.sln +++ b/src/Calculator.sln @@ -1,7 +1,7 @@  Microsoft Visual Studio Solution File, Format Version 12.00 -# Visual Studio 15 -VisualStudioVersion = 15.0.27130.2036 +# Visual Studio Version 16 +VisualStudioVersion = 16.0.29009.5 MinimumVisualStudioVersion = 10.0.40219.1 Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "Calculator", "Calculator\Calculator.vcxproj", "{9447424A-0E05-4911-BEB8-E0354405F39A}" EndProject diff --git a/src/Calculator/App.xaml.cpp b/src/Calculator/App.xaml.cpp index c8b29dd..5fe8152 100644 --- a/src/Calculator/App.xaml.cpp +++ b/src/Calculator/App.xaml.cpp @@ -165,6 +165,7 @@ task App::HandleViewReleaseAndRemoveWindowFromMap(_In_ WindowFrameService task_continuation_context::use_arbitrary()); } +#pragma optimize("", off) // Turn off optimizations to work around coroutine optimization bug task App::SetupJumpList() { try @@ -190,7 +191,8 @@ task App::SetupJumpList() catch (...) { } -} +}; +#pragma optimize("", on) void App::RemoveSecondaryWindow(_In_ WindowFrameService ^ frameService) { diff --git a/src/Calculator/Calculator.vcxproj b/src/Calculator/Calculator.vcxproj index 667e6c9..c20681a 100644 --- a/src/Calculator/Calculator.vcxproj +++ b/src/Calculator/Calculator.vcxproj @@ -62,46 +62,46 @@ Application true - v141 + v142 Application true - v141 + v142 Application true - v141 + v142 Application true - v141 + v142 Application false true - v141 + v142 Application false true - v141 + v142 Application false true - v141 + v142 Application false true - v141 + v142 diff --git a/src/CalculatorUnitTests/CalculatorUnitTests.vcxproj b/src/CalculatorUnitTests/CalculatorUnitTests.vcxproj index 7fa08fc..465088f 100644 --- a/src/CalculatorUnitTests/CalculatorUnitTests.vcxproj +++ b/src/CalculatorUnitTests/CalculatorUnitTests.vcxproj @@ -55,50 +55,50 @@ Application true - v141 + v142 Application true - v141 + v142 Application true - v141 + v142 true Application true - v141 + v142 Application false true - v141 + v142 true Application false true - v141 + v142 true Application false true - v141 + v142 true Application false true - v141 + v142 true