From 2a29947a28cb0efae769ccbfdc3205eee6159a8b Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 22 Apr 2019 17:30:59 -0700 Subject: [PATCH] Collapse CurrencySecondaryStatus when no text is present in the text block (#467) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes #313 In Scan/Item mode, Narrator focus navigates to hidden element “No next item” after “Update rates” link in "Currency Converter" window #313 Description of the changes: Adds an x:Name to the CurrencySecondaryStatus text block Adds a NormalCurrencyStatus visual state to the CurrencySecondaryStatusStates Adds functionality to the CurrencySecondaryStatusStates to show or hide the CurrencySecondaryStatus text block. How changes were validated: Verified that the textblock is not visible in the accessibility tree via inspect.exe from the windows sdk. Verified that Narrator also does not stop on the block when in scan mode. Verified that the textblock is visible in the accessibility tree and read out in Narrator when the ChargesMayApplyCurrencyStatus or FailedCurrencyStatus viewstates are set. --- src/Calculator/Views/UnitConverter.xaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Calculator/Views/UnitConverter.xaml b/src/Calculator/Views/UnitConverter.xaml index 1d52c3e..a1a0a8d 100644 --- a/src/Calculator/Views/UnitConverter.xaml +++ b/src/Calculator/Views/UnitConverter.xaml @@ -615,8 +615,7 @@ x:Uid="RefreshButtonText" Foreground="{ThemeResource SystemControlHyperlinkBaseHighBrush}" Click="CurrencyRefreshButton_Click"/> - - +